123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338 |
- package main
- import (
- "context"
- "errors"
- "fmt"
- "io"
- "os"
- "os/exec"
- "strings"
- "testing"
- "github.com/stretchr/testify/assert"
- "github.com/stretchr/testify/require"
- "github.com/Jguer/yay/v12/pkg/db/mock"
- "github.com/Jguer/yay/v12/pkg/dep"
- "github.com/Jguer/yay/v12/pkg/settings/exe"
- "github.com/Jguer/yay/v12/pkg/settings/parser"
- "github.com/Jguer/yay/v12/pkg/text"
- "github.com/Jguer/yay/v12/pkg/vcs"
- )
- func NewTestLogger() *text.Logger {
- return text.NewLogger(io.Discard, io.Discard, strings.NewReader(""), true, "test")
- }
- func ptrString(s string) *string {
- return &s
- }
- func TestInstaller_InstallNeeded(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- isInstalled bool
- isBuilt bool
- wantShow []string
- wantCapture []string
- }
- testCases := []testCase{
- {
- desc: "not installed and not built",
- isInstalled: false,
- isBuilt: false,
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --needed --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- },
- {
- desc: "not installed and built",
- isInstalled: false,
- isBuilt: true,
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- "pacman -U --needed --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- },
- {
- desc: "installed",
- isInstalled: true,
- isBuilt: false,
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- },
- wantCapture: []string{"makepkg --packagelist"},
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- tmpDir := td.TempDir()
- pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- return pkgTar, "", nil
- }
- i := 0
- showOverride := func(cmd *exec.Cmd) error {
- i++
- if i == 2 {
- if !tc.isBuilt {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- }
- return nil
- }
- // create a mock file
- if tc.isBuilt {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- isCorrectInstalledOverride := func(string, string) bool {
- return tc.isInstalled
- }
- mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- parser.RebuildModeNo, false, NewTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddArg("needed")
- cmdArgs.AddTarget("yay")
- pkgBuildDirs := map[string]string{
- "yay": tmpDir,
- }
- targets := []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- }
- errI := installer.Install(context.Background(), cmdArgs, targets, pkgBuildDirs, []string{}, false)
- require.NoError(td, errI)
- require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
- require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
- for i, call := range mockRunner.ShowCalls {
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- // options are in a different order on different systems and on CI root user is used
- assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
- }
- for i, call := range mockRunner.CaptureCalls {
- capture := call.Args[0].(*exec.Cmd).String()
- capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
- capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
- capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
- assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
- }
- })
- }
- }
- func TestInstaller_InstallMixedSourcesAndLayers(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- targets []map[string]*dep.InstallInfo
- wantShow []string
- wantCapture []string
- }
- tmpDir := t.TempDir()
- tmpDirJfin := t.TempDir()
- testCases := []testCase{
- {
- desc: "same layer -- different sources",
- wantShow: []string{
- "pacman -S --config /etc/pacman.conf -- core/linux",
- "pacman -D -q --asdeps --config /etc/pacman.conf -- linux",
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- "linux": {
- Source: dep.Sync,
- Reason: dep.Dep,
- Version: "17.0.0-1",
- SyncDBName: ptrString("core"),
- },
- },
- },
- },
- {
- desc: "different layer -- different sources",
- wantShow: []string{
- "pacman -S --config /etc/pacman.conf -- core/linux",
- "pacman -D -q --asdeps --config /etc/pacman.conf -- linux",
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- }, {
- "linux": {
- Source: dep.Sync,
- Reason: dep.Dep,
- Version: "17.0.0-1",
- SyncDBName: ptrString("core"),
- },
- },
- },
- },
- {
- desc: "same layer -- sync",
- wantShow: []string{
- "pacman -S --config /etc/pacman.conf -- extra/linux-zen core/linux",
- "pacman -D -q --asexplicit --config /etc/pacman.conf -- linux-zen linux",
- },
- wantCapture: []string{},
- targets: []map[string]*dep.InstallInfo{
- {
- "linux-zen": {
- Source: dep.Sync,
- Reason: dep.Explicit,
- Version: "18.0.0-1",
- SyncDBName: ptrString("extra"),
- },
- "linux": {
- Source: dep.Sync,
- Reason: dep.Explicit,
- Version: "17.0.0-1",
- SyncDBName: ptrString("core"),
- },
- },
- },
- },
- {
- desc: "same layer -- aur",
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config /etc/pacman.conf -- pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
- },
- wantCapture: []string{"makepkg --packagelist", "makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- "jellyfin-server": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "10.8.8-1",
- SrcinfoPath: ptrString(tmpDirJfin + "/.SRCINFO"),
- AURBase: ptrString("jellyfin"),
- },
- },
- },
- },
- {
- desc: "different layer -- aur",
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config /etc/pacman.conf -- pacman -U --config /etc/pacman.conf -- /testdir/jellyfin-server-10.8.8-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asdeps --config /etc/pacman.conf -- jellyfin-server",
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config /etc/pacman.conf -- pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
- },
- wantCapture: []string{"makepkg --packagelist", "makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- }, {
- "jellyfin-server": {
- Source: dep.AUR,
- Reason: dep.MakeDep,
- Version: "10.8.8-1",
- SrcinfoPath: ptrString(tmpDirJfin + "/.SRCINFO"),
- AURBase: ptrString("jellyfin"),
- },
- },
- },
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
- jfinPkgTar := tmpDirJfin + "/jellyfin-server-10.8.8-1-x86_64.pkg.tar.zst"
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- if cmd.Dir == tmpDirJfin {
- return jfinPkgTar, "", nil
- }
- if cmd.Dir == tmpDir {
- return pkgTar, "", nil
- }
- return "", "", fmt.Errorf("unexpected command: %s - %s", cmd.String(), cmd.Dir)
- }
- showOverride := func(cmd *exec.Cmd) error {
- if strings.Contains(cmd.String(), "makepkg -cf --noconfirm") && cmd.Dir == tmpDir {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- if strings.Contains(cmd.String(), "makepkg -cf --noconfirm") && cmd.Dir == tmpDirJfin {
- f, err := os.OpenFile(jfinPkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- return nil
- }
- defer os.Remove(pkgTar)
- defer os.Remove(jfinPkgTar)
- isCorrectInstalledOverride := func(string, string) bool {
- return false
- }
- mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- PacmanConfigPath: "/etc/pacman.conf",
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny, parser.RebuildModeNo, false, NewTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddTarget("yay")
- pkgBuildDirs := map[string]string{
- "yay": tmpDir,
- "jellyfin": tmpDirJfin,
- }
- errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
- require.NoError(td, errI)
- require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
- require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
- for i, call := range mockRunner.ShowCalls {
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, tmpDirJfin, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- // options are in a different order on different systems and on CI root user is used
- assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
- }
- for i, call := range mockRunner.CaptureCalls {
- capture := call.Args[0].(*exec.Cmd).String()
- capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
- capture = strings.ReplaceAll(capture, tmpDirJfin, "/testdir")
- capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
- capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
- assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
- }
- })
- }
- }
- func TestInstaller_RunPostHooks(t *testing.T) {
- mockDB := &mock.DBExecutor{}
- mockRunner := &exe.MockRunner{}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: "makepkg",
- SudoBin: "su",
- PacmanBin: "pacman",
- PacmanConfigPath: "/etc/pacman.conf",
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- parser.RebuildModeNo, false, NewTestLogger())
- called := false
- hook := func(ctx context.Context) error {
- called = true
- return nil
- }
- installer.AddPostInstallHook(hook)
- installer.RunPostInstallHooks(context.Background())
- assert.True(t, called)
- }
- func TestInstaller_CompileFailed(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- targets []map[string]*dep.InstallInfo
- wantErrInstall bool
- wantErrCompile bool
- failBuild bool
- failPkgInstall bool
- }
- tmpDir := t.TempDir()
- testCases := []testCase{
- {
- desc: "one layer",
- wantErrInstall: false,
- wantErrCompile: true,
- failBuild: true,
- failPkgInstall: false,
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- {
- desc: "one layer -- fail install",
- wantErrInstall: true,
- wantErrCompile: false,
- failBuild: false,
- failPkgInstall: true,
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- {
- desc: "two layers",
- wantErrInstall: false,
- wantErrCompile: true,
- failBuild: true,
- failPkgInstall: false,
- targets: []map[string]*dep.InstallInfo{
- {"bob": {
- AURBase: ptrString("yay"),
- }},
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- return pkgTar, "", nil
- }
- showOverride := func(cmd *exec.Cmd) error {
- if tc.failBuild && strings.Contains(cmd.String(), "makepkg -cf --noconfirm") && cmd.Dir == tmpDir {
- return errors.New("makepkg failed")
- }
- return nil
- }
- isCorrectInstalledOverride := func(string, string) bool {
- return false
- }
- mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- parser.RebuildModeNo, false, NewTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddArg("needed")
- cmdArgs.AddTarget("yay")
- pkgBuildDirs := map[string]string{
- "yay": tmpDir,
- }
- errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
- if tc.wantErrInstall {
- require.Error(td, errI)
- } else {
- require.NoError(td, errI)
- }
- err := installer.CompileFailedAndIgnored()
- if tc.wantErrCompile {
- require.Error(td, err)
- assert.ErrorContains(td, err, "yay")
- } else {
- require.NoError(td, err)
- }
- })
- }
- }
- func TestInstaller_InstallSplitPackage(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- wantShow []string
- wantCapture []string
- targets []map[string]*dep.InstallInfo
- }
- tmpDir := t.TempDir()
- testCases := []testCase{
- {
- desc: "jellyfin",
- targets: []map[string]*dep.InstallInfo{
- {"jellyfin": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "10.8.4-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("jellyfin"),
- }},
- {
- "jellyfin-server": {
- Source: dep.AUR,
- Reason: dep.Dep,
- Version: "10.8.4-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("jellyfin"),
- },
- "jellyfin-web": {
- Source: dep.AUR,
- Reason: dep.Dep,
- Version: "10.8.4-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("jellyfin"),
- },
- },
- {
- "dotnet-runtime-6.0": {
- Source: dep.Sync,
- Reason: dep.Dep,
- Version: "6.0.12.sdk112-1",
- SyncDBName: ptrString("community"),
- },
- "aspnet-runtime": {
- Source: dep.Sync,
- Reason: dep.Dep,
- Version: "6.0.12.sdk112-1",
- SyncDBName: ptrString("community"),
- },
- "dotnet-sdk-6.0": {
- Source: dep.Sync,
- Reason: dep.MakeDep,
- Version: "6.0.12.sdk112-1",
- SyncDBName: ptrString("community"),
- },
- },
- },
- wantShow: []string{
- "pacman -S --config /etc/pacman.conf -- community/dotnet-runtime-6.0 community/aspnet-runtime community/dotnet-sdk-6.0",
- "pacman -D -q --asdeps --config /etc/pacman.conf -- dotnet-runtime-6.0 aspnet-runtime dotnet-sdk-6.0",
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- "pacman -U --config /etc/pacman.conf -- /testdir/jellyfin-web-10.8.4-1-x86_64.pkg.tar.zst /testdir/jellyfin-server-10.8.4-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asdeps --config /etc/pacman.conf -- jellyfin-server jellyfin-web",
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- "pacman -U --config /etc/pacman.conf -- /testdir/jellyfin-10.8.4-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config /etc/pacman.conf -- jellyfin",
- },
- wantCapture: []string{"makepkg --packagelist", "makepkg --packagelist", "makepkg --packagelist"},
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- pkgTars := []string{
- tmpDir + "/jellyfin-10.8.4-1-x86_64.pkg.tar.zst",
- tmpDir + "/jellyfin-web-10.8.4-1-x86_64.pkg.tar.zst",
- tmpDir + "/jellyfin-server-10.8.4-1-x86_64.pkg.tar.zst",
- }
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- return strings.Join(pkgTars, "\n"), "", nil
- }
- i := 0
- showOverride := func(cmd *exec.Cmd) error {
- i++
- if i == 4 {
- for _, pkgTar := range pkgTars {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- }
- return nil
- }
- isCorrectInstalledOverride := func(string, string) bool {
- return false
- }
- mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- PacmanConfigPath: "/etc/pacman.conf",
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- parser.RebuildModeNo, false, NewTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddTarget("jellyfin")
- pkgBuildDirs := map[string]string{
- "jellyfin": tmpDir,
- }
- errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
- require.NoError(td, errI)
- require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
- require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
- for i, call := range mockRunner.ShowCalls {
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- // options are in a different order on different systems and on CI root user is used
- assert.Subset(td, strings.Split(show, " "),
- strings.Split(tc.wantShow[i], " "),
- fmt.Sprintf("got at %d: %s \n", i, show))
- }
- for i, call := range mockRunner.CaptureCalls {
- capture := call.Args[0].(*exec.Cmd).String()
- capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
- capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
- capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
- assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
- }
- })
- }
- }
- func TestInstaller_InstallDownloadOnly(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- isInstalled bool
- isBuilt bool
- wantShow []string
- wantCapture []string
- }
- testCases := []testCase{
- {
- desc: "not installed and not built",
- isInstalled: false,
- isBuilt: false,
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- },
- wantCapture: []string{"makepkg --packagelist"},
- },
- {
- desc: "not installed and built",
- isInstalled: false,
- isBuilt: true,
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- },
- wantCapture: []string{"makepkg --packagelist"},
- },
- {
- desc: "installed",
- isInstalled: true,
- isBuilt: false,
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- },
- wantCapture: []string{"makepkg --packagelist"},
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- tmpDir := td.TempDir()
- pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- return pkgTar, "", nil
- }
- i := 0
- showOverride := func(cmd *exec.Cmd) error {
- i++
- if i == 2 {
- if !tc.isBuilt {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- }
- return nil
- }
- // create a mock file
- if tc.isBuilt {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- isCorrectInstalledOverride := func(string, string) bool {
- return tc.isInstalled
- }
- mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- parser.RebuildModeNo, true, NewTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddTarget("yay")
- pkgBuildDirs := map[string]string{
- "yay": tmpDir,
- }
- targets := []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- }
- errI := installer.Install(context.Background(), cmdArgs, targets, pkgBuildDirs, []string{}, false)
- require.NoError(td, errI)
- require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
- require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
- require.Empty(td, installer.failedAndIgnored)
- for i, call := range mockRunner.ShowCalls {
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- // options are in a different order on different systems and on CI root user is used
- assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
- }
- for i, call := range mockRunner.CaptureCalls {
- capture := call.Args[0].(*exec.Cmd).String()
- capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
- capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
- capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
- assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
- }
- })
- }
- }
- func TestInstaller_InstallGroup(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- wantShow []string
- wantCapture []string
- }
- testCases := []testCase{
- {
- desc: "group",
- wantShow: []string{
- "pacman -S --noconfirm --config -- community/kubernetes-tools",
- },
- wantCapture: []string{},
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- tmpDir := td.TempDir()
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- return "", "", nil
- }
- showOverride := func(cmd *exec.Cmd) error {
- return nil
- }
- mockDB := &mock.DBExecutor{}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- parser.RebuildModeNo, true, NewTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddTarget("kubernetes-tools")
- pkgBuildDirs := map[string]string{}
- targets := []map[string]*dep.InstallInfo{
- {
- "kubernetes-tools": {
- Source: dep.Sync,
- Reason: dep.Explicit,
- Version: "",
- IsGroup: true,
- SyncDBName: ptrString("community"),
- },
- },
- }
- errI := installer.Install(context.Background(), cmdArgs, targets, pkgBuildDirs, []string{}, false)
- require.NoError(td, errI)
- require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
- require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
- require.Empty(td, installer.failedAndIgnored)
- for i, call := range mockRunner.ShowCalls {
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- // options are in a different order on different systems and on CI root user is used
- assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
- }
- for i, call := range mockRunner.CaptureCalls {
- capture := call.Args[0].(*exec.Cmd).String()
- capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
- capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
- capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
- assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
- }
- })
- }
- }
- func TestInstaller_InstallRebuild(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- rebuildOption parser.RebuildMode
- isInstalled bool
- isBuilt bool
- wantShow []string
- wantCapture []string
- targets []map[string]*dep.InstallInfo
- }
- tmpDir := t.TempDir()
- testCases := []testCase{
- {
- desc: "--norebuild(default) when built and not installed",
- rebuildOption: parser.RebuildModeNo,
- isBuilt: true,
- isInstalled: false,
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- {
- desc: "--rebuild when built and not installed",
- rebuildOption: parser.RebuildModeYes,
- isBuilt: true,
- isInstalled: false,
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- {
- desc: "--rebuild when built and installed",
- rebuildOption: parser.RebuildModeYes,
- isInstalled: true,
- isBuilt: true,
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- {
- desc: "--rebuild when built and installed previously as dep",
- rebuildOption: parser.RebuildModeYes,
- isInstalled: true,
- isBuilt: true,
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asdeps --config -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Dep,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- tmpDir := td.TempDir()
- pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- return pkgTar, "", nil
- }
- i := 0
- showOverride := func(cmd *exec.Cmd) error {
- i++
- if i == 2 {
- if !tc.isBuilt {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- }
- return nil
- }
- // create a mock file
- if tc.isBuilt {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- isCorrectInstalledOverride := func(string, string) bool {
- return tc.isInstalled
- }
- mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- tc.rebuildOption, false, NewTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddTarget("yay")
- pkgBuildDirs := map[string]string{
- "yay": tmpDir,
- }
- errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
- require.NoError(td, errI)
- require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
- require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
- for i, call := range mockRunner.ShowCalls {
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- // options are in a different order on different systems and on CI root user is used
- assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
- }
- for i, call := range mockRunner.CaptureCalls {
- capture := call.Args[0].(*exec.Cmd).String()
- capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
- capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
- capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
- assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
- }
- })
- }
- }
- func TestInstaller_InstallUpgrade(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- targetMode parser.TargetMode
- }
- tmpDir := t.TempDir()
- testCases := []testCase{
- {
- desc: "target any",
- targetMode: parser.ModeAny,
- },
- {
- desc: "target repo",
- targetMode: parser.ModeRepo,
- },
- {
- desc: "target aur",
- targetMode: parser.ModeAUR,
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- mockDB := &mock.DBExecutor{}
- mockRunner := &exe.MockRunner{}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, tc.targetMode,
- parser.RebuildModeNo, false, NewTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddArg("u", "upgrades") // Make sure both args are removed
- targets := []map[string]*dep.InstallInfo{
- {
- "linux": {
- Source: dep.Sync,
- Reason: dep.Dep,
- Version: "17.0.0-1",
- SyncDBName: ptrString("core"),
- },
- },
- }
- errI := installer.Install(context.Background(), cmdArgs, targets, map[string]string{}, []string{}, false)
- require.NoError(td, errI)
- require.NotEmpty(td, mockRunner.ShowCalls)
- // The first call is the only call being test
- call := mockRunner.ShowCalls[0]
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- if tc.targetMode == parser.ModeAUR {
- assert.NotContains(td, show, "--upgrades")
- assert.NotContains(td, show, "-u")
- } else {
- assert.Contains(td, show, "--upgrades")
- assert.Contains(td, show, "-u")
- }
- })
- }
- }
|