aur_install_test.go 39 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338
  1. package main
  2. import (
  3. "context"
  4. "errors"
  5. "fmt"
  6. "io"
  7. "os"
  8. "os/exec"
  9. "strings"
  10. "testing"
  11. "github.com/stretchr/testify/assert"
  12. "github.com/stretchr/testify/require"
  13. "github.com/Jguer/yay/v12/pkg/db/mock"
  14. "github.com/Jguer/yay/v12/pkg/dep"
  15. "github.com/Jguer/yay/v12/pkg/settings/exe"
  16. "github.com/Jguer/yay/v12/pkg/settings/parser"
  17. "github.com/Jguer/yay/v12/pkg/text"
  18. "github.com/Jguer/yay/v12/pkg/vcs"
  19. )
  20. func NewTestLogger() *text.Logger {
  21. return text.NewLogger(io.Discard, io.Discard, strings.NewReader(""), true, "test")
  22. }
  23. func ptrString(s string) *string {
  24. return &s
  25. }
  26. func TestInstaller_InstallNeeded(t *testing.T) {
  27. t.Parallel()
  28. makepkgBin := t.TempDir() + "/makepkg"
  29. pacmanBin := t.TempDir() + "/pacman"
  30. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  31. require.NoError(t, err)
  32. require.NoError(t, f.Close())
  33. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  34. require.NoError(t, err)
  35. require.NoError(t, f.Close())
  36. type testCase struct {
  37. desc string
  38. isInstalled bool
  39. isBuilt bool
  40. wantShow []string
  41. wantCapture []string
  42. }
  43. testCases := []testCase{
  44. {
  45. desc: "not installed and not built",
  46. isInstalled: false,
  47. isBuilt: false,
  48. wantShow: []string{
  49. "makepkg --nobuild -fC --ignorearch",
  50. "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
  51. "pacman -U --needed --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  52. "pacman -D -q --asexplicit --config -- yay",
  53. },
  54. wantCapture: []string{"makepkg --packagelist"},
  55. },
  56. {
  57. desc: "not installed and built",
  58. isInstalled: false,
  59. isBuilt: true,
  60. wantShow: []string{
  61. "makepkg --nobuild -fC --ignorearch",
  62. "makepkg -c --nobuild --noextract --ignorearch",
  63. "pacman -U --needed --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  64. "pacman -D -q --asexplicit --config -- yay",
  65. },
  66. wantCapture: []string{"makepkg --packagelist"},
  67. },
  68. {
  69. desc: "installed",
  70. isInstalled: true,
  71. isBuilt: false,
  72. wantShow: []string{
  73. "makepkg --nobuild -fC --ignorearch",
  74. "makepkg -c --nobuild --noextract --ignorearch",
  75. },
  76. wantCapture: []string{"makepkg --packagelist"},
  77. },
  78. }
  79. for _, tc := range testCases {
  80. tc := tc
  81. t.Run(tc.desc, func(td *testing.T) {
  82. tmpDir := td.TempDir()
  83. pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
  84. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  85. return pkgTar, "", nil
  86. }
  87. i := 0
  88. showOverride := func(cmd *exec.Cmd) error {
  89. i++
  90. if i == 2 {
  91. if !tc.isBuilt {
  92. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  93. require.NoError(td, err)
  94. require.NoError(td, f.Close())
  95. }
  96. }
  97. return nil
  98. }
  99. // create a mock file
  100. if tc.isBuilt {
  101. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  102. require.NoError(td, err)
  103. require.NoError(td, f.Close())
  104. }
  105. isCorrectInstalledOverride := func(string, string) bool {
  106. return tc.isInstalled
  107. }
  108. mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
  109. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  110. cmdBuilder := &exe.CmdBuilder{
  111. MakepkgBin: makepkgBin,
  112. SudoBin: "su",
  113. PacmanBin: pacmanBin,
  114. Runner: mockRunner,
  115. SudoLoopEnabled: false,
  116. }
  117. cmdBuilder.Runner = mockRunner
  118. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  119. parser.RebuildModeNo, false, NewTestLogger())
  120. cmdArgs := parser.MakeArguments()
  121. cmdArgs.AddArg("needed")
  122. cmdArgs.AddTarget("yay")
  123. pkgBuildDirs := map[string]string{
  124. "yay": tmpDir,
  125. }
  126. targets := []map[string]*dep.InstallInfo{
  127. {
  128. "yay": {
  129. Source: dep.AUR,
  130. Reason: dep.Explicit,
  131. Version: "91.0.0-1",
  132. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  133. AURBase: ptrString("yay"),
  134. },
  135. },
  136. }
  137. errI := installer.Install(context.Background(), cmdArgs, targets, pkgBuildDirs, []string{}, false)
  138. require.NoError(td, errI)
  139. require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
  140. require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
  141. for i, call := range mockRunner.ShowCalls {
  142. show := call.Args[0].(*exec.Cmd).String()
  143. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  144. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  145. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  146. // options are in a different order on different systems and on CI root user is used
  147. assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
  148. }
  149. for i, call := range mockRunner.CaptureCalls {
  150. capture := call.Args[0].(*exec.Cmd).String()
  151. capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
  152. capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
  153. capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
  154. assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
  155. }
  156. })
  157. }
  158. }
  159. func TestInstaller_InstallMixedSourcesAndLayers(t *testing.T) {
  160. t.Parallel()
  161. makepkgBin := t.TempDir() + "/makepkg"
  162. pacmanBin := t.TempDir() + "/pacman"
  163. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  164. require.NoError(t, err)
  165. require.NoError(t, f.Close())
  166. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  167. require.NoError(t, err)
  168. require.NoError(t, f.Close())
  169. type testCase struct {
  170. desc string
  171. targets []map[string]*dep.InstallInfo
  172. wantShow []string
  173. wantCapture []string
  174. }
  175. tmpDir := t.TempDir()
  176. tmpDirJfin := t.TempDir()
  177. testCases := []testCase{
  178. {
  179. desc: "same layer -- different sources",
  180. wantShow: []string{
  181. "pacman -S --config /etc/pacman.conf -- core/linux",
  182. "pacman -D -q --asdeps --config /etc/pacman.conf -- linux",
  183. "makepkg --nobuild -fC --ignorearch",
  184. "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
  185. "pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  186. "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
  187. },
  188. wantCapture: []string{"makepkg --packagelist"},
  189. targets: []map[string]*dep.InstallInfo{
  190. {
  191. "yay": {
  192. Source: dep.AUR,
  193. Reason: dep.Explicit,
  194. Version: "91.0.0-1",
  195. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  196. AURBase: ptrString("yay"),
  197. },
  198. "linux": {
  199. Source: dep.Sync,
  200. Reason: dep.Dep,
  201. Version: "17.0.0-1",
  202. SyncDBName: ptrString("core"),
  203. },
  204. },
  205. },
  206. },
  207. {
  208. desc: "different layer -- different sources",
  209. wantShow: []string{
  210. "pacman -S --config /etc/pacman.conf -- core/linux",
  211. "pacman -D -q --asdeps --config /etc/pacman.conf -- linux",
  212. "makepkg --nobuild -fC --ignorearch",
  213. "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
  214. "pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  215. "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
  216. },
  217. wantCapture: []string{"makepkg --packagelist"},
  218. targets: []map[string]*dep.InstallInfo{
  219. {
  220. "yay": {
  221. Source: dep.AUR,
  222. Reason: dep.Explicit,
  223. Version: "91.0.0-1",
  224. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  225. AURBase: ptrString("yay"),
  226. },
  227. }, {
  228. "linux": {
  229. Source: dep.Sync,
  230. Reason: dep.Dep,
  231. Version: "17.0.0-1",
  232. SyncDBName: ptrString("core"),
  233. },
  234. },
  235. },
  236. },
  237. {
  238. desc: "same layer -- sync",
  239. wantShow: []string{
  240. "pacman -S --config /etc/pacman.conf -- extra/linux-zen core/linux",
  241. "pacman -D -q --asexplicit --config /etc/pacman.conf -- linux-zen linux",
  242. },
  243. wantCapture: []string{},
  244. targets: []map[string]*dep.InstallInfo{
  245. {
  246. "linux-zen": {
  247. Source: dep.Sync,
  248. Reason: dep.Explicit,
  249. Version: "18.0.0-1",
  250. SyncDBName: ptrString("extra"),
  251. },
  252. "linux": {
  253. Source: dep.Sync,
  254. Reason: dep.Explicit,
  255. Version: "17.0.0-1",
  256. SyncDBName: ptrString("core"),
  257. },
  258. },
  259. },
  260. },
  261. {
  262. desc: "same layer -- aur",
  263. wantShow: []string{
  264. "makepkg --nobuild -fC --ignorearch",
  265. "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
  266. "makepkg --nobuild -fC --ignorearch",
  267. "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
  268. "pacman -U --config /etc/pacman.conf -- pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  269. "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
  270. },
  271. wantCapture: []string{"makepkg --packagelist", "makepkg --packagelist"},
  272. targets: []map[string]*dep.InstallInfo{
  273. {
  274. "yay": {
  275. Source: dep.AUR,
  276. Reason: dep.Explicit,
  277. Version: "91.0.0-1",
  278. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  279. AURBase: ptrString("yay"),
  280. },
  281. "jellyfin-server": {
  282. Source: dep.AUR,
  283. Reason: dep.Explicit,
  284. Version: "10.8.8-1",
  285. SrcinfoPath: ptrString(tmpDirJfin + "/.SRCINFO"),
  286. AURBase: ptrString("jellyfin"),
  287. },
  288. },
  289. },
  290. },
  291. {
  292. desc: "different layer -- aur",
  293. wantShow: []string{
  294. "makepkg --nobuild -fC --ignorearch",
  295. "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
  296. "pacman -U --config /etc/pacman.conf -- pacman -U --config /etc/pacman.conf -- /testdir/jellyfin-server-10.8.8-1-x86_64.pkg.tar.zst",
  297. "pacman -D -q --asdeps --config /etc/pacman.conf -- jellyfin-server",
  298. "makepkg --nobuild -fC --ignorearch",
  299. "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
  300. "pacman -U --config /etc/pacman.conf -- pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  301. "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
  302. },
  303. wantCapture: []string{"makepkg --packagelist", "makepkg --packagelist"},
  304. targets: []map[string]*dep.InstallInfo{
  305. {
  306. "yay": {
  307. Source: dep.AUR,
  308. Reason: dep.Explicit,
  309. Version: "91.0.0-1",
  310. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  311. AURBase: ptrString("yay"),
  312. },
  313. }, {
  314. "jellyfin-server": {
  315. Source: dep.AUR,
  316. Reason: dep.MakeDep,
  317. Version: "10.8.8-1",
  318. SrcinfoPath: ptrString(tmpDirJfin + "/.SRCINFO"),
  319. AURBase: ptrString("jellyfin"),
  320. },
  321. },
  322. },
  323. },
  324. }
  325. for _, tc := range testCases {
  326. tc := tc
  327. t.Run(tc.desc, func(td *testing.T) {
  328. pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
  329. jfinPkgTar := tmpDirJfin + "/jellyfin-server-10.8.8-1-x86_64.pkg.tar.zst"
  330. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  331. if cmd.Dir == tmpDirJfin {
  332. return jfinPkgTar, "", nil
  333. }
  334. if cmd.Dir == tmpDir {
  335. return pkgTar, "", nil
  336. }
  337. return "", "", fmt.Errorf("unexpected command: %s - %s", cmd.String(), cmd.Dir)
  338. }
  339. showOverride := func(cmd *exec.Cmd) error {
  340. if strings.Contains(cmd.String(), "makepkg -cf --noconfirm") && cmd.Dir == tmpDir {
  341. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  342. require.NoError(td, err)
  343. require.NoError(td, f.Close())
  344. }
  345. if strings.Contains(cmd.String(), "makepkg -cf --noconfirm") && cmd.Dir == tmpDirJfin {
  346. f, err := os.OpenFile(jfinPkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  347. require.NoError(td, err)
  348. require.NoError(td, f.Close())
  349. }
  350. return nil
  351. }
  352. defer os.Remove(pkgTar)
  353. defer os.Remove(jfinPkgTar)
  354. isCorrectInstalledOverride := func(string, string) bool {
  355. return false
  356. }
  357. mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
  358. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  359. cmdBuilder := &exe.CmdBuilder{
  360. MakepkgBin: makepkgBin,
  361. SudoBin: "su",
  362. PacmanBin: pacmanBin,
  363. PacmanConfigPath: "/etc/pacman.conf",
  364. Runner: mockRunner,
  365. SudoLoopEnabled: false,
  366. }
  367. cmdBuilder.Runner = mockRunner
  368. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny, parser.RebuildModeNo, false, NewTestLogger())
  369. cmdArgs := parser.MakeArguments()
  370. cmdArgs.AddTarget("yay")
  371. pkgBuildDirs := map[string]string{
  372. "yay": tmpDir,
  373. "jellyfin": tmpDirJfin,
  374. }
  375. errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
  376. require.NoError(td, errI)
  377. require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
  378. require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
  379. for i, call := range mockRunner.ShowCalls {
  380. show := call.Args[0].(*exec.Cmd).String()
  381. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  382. show = strings.ReplaceAll(show, tmpDirJfin, "/testdir") // replace the temp dir with a static path
  383. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  384. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  385. // options are in a different order on different systems and on CI root user is used
  386. assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
  387. }
  388. for i, call := range mockRunner.CaptureCalls {
  389. capture := call.Args[0].(*exec.Cmd).String()
  390. capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
  391. capture = strings.ReplaceAll(capture, tmpDirJfin, "/testdir")
  392. capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
  393. capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
  394. assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
  395. }
  396. })
  397. }
  398. }
  399. func TestInstaller_RunPostHooks(t *testing.T) {
  400. mockDB := &mock.DBExecutor{}
  401. mockRunner := &exe.MockRunner{}
  402. cmdBuilder := &exe.CmdBuilder{
  403. MakepkgBin: "makepkg",
  404. SudoBin: "su",
  405. PacmanBin: "pacman",
  406. PacmanConfigPath: "/etc/pacman.conf",
  407. Runner: mockRunner,
  408. SudoLoopEnabled: false,
  409. }
  410. cmdBuilder.Runner = mockRunner
  411. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  412. parser.RebuildModeNo, false, NewTestLogger())
  413. called := false
  414. hook := func(ctx context.Context) error {
  415. called = true
  416. return nil
  417. }
  418. installer.AddPostInstallHook(hook)
  419. installer.RunPostInstallHooks(context.Background())
  420. assert.True(t, called)
  421. }
  422. func TestInstaller_CompileFailed(t *testing.T) {
  423. t.Parallel()
  424. makepkgBin := t.TempDir() + "/makepkg"
  425. pacmanBin := t.TempDir() + "/pacman"
  426. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  427. require.NoError(t, err)
  428. require.NoError(t, f.Close())
  429. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  430. require.NoError(t, err)
  431. require.NoError(t, f.Close())
  432. type testCase struct {
  433. desc string
  434. targets []map[string]*dep.InstallInfo
  435. wantErrInstall bool
  436. wantErrCompile bool
  437. failBuild bool
  438. failPkgInstall bool
  439. }
  440. tmpDir := t.TempDir()
  441. testCases := []testCase{
  442. {
  443. desc: "one layer",
  444. wantErrInstall: false,
  445. wantErrCompile: true,
  446. failBuild: true,
  447. failPkgInstall: false,
  448. targets: []map[string]*dep.InstallInfo{
  449. {
  450. "yay": {
  451. Source: dep.AUR,
  452. Reason: dep.Explicit,
  453. Version: "91.0.0-1",
  454. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  455. AURBase: ptrString("yay"),
  456. },
  457. },
  458. },
  459. },
  460. {
  461. desc: "one layer -- fail install",
  462. wantErrInstall: true,
  463. wantErrCompile: false,
  464. failBuild: false,
  465. failPkgInstall: true,
  466. targets: []map[string]*dep.InstallInfo{
  467. {
  468. "yay": {
  469. Source: dep.AUR,
  470. Reason: dep.Explicit,
  471. Version: "91.0.0-1",
  472. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  473. AURBase: ptrString("yay"),
  474. },
  475. },
  476. },
  477. },
  478. {
  479. desc: "two layers",
  480. wantErrInstall: false,
  481. wantErrCompile: true,
  482. failBuild: true,
  483. failPkgInstall: false,
  484. targets: []map[string]*dep.InstallInfo{
  485. {"bob": {
  486. AURBase: ptrString("yay"),
  487. }},
  488. {
  489. "yay": {
  490. Source: dep.AUR,
  491. Reason: dep.Explicit,
  492. Version: "91.0.0-1",
  493. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  494. AURBase: ptrString("yay"),
  495. },
  496. },
  497. },
  498. },
  499. }
  500. for _, tc := range testCases {
  501. tc := tc
  502. t.Run(tc.desc, func(td *testing.T) {
  503. pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
  504. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  505. return pkgTar, "", nil
  506. }
  507. showOverride := func(cmd *exec.Cmd) error {
  508. if tc.failBuild && strings.Contains(cmd.String(), "makepkg -cf --noconfirm") && cmd.Dir == tmpDir {
  509. return errors.New("makepkg failed")
  510. }
  511. return nil
  512. }
  513. isCorrectInstalledOverride := func(string, string) bool {
  514. return false
  515. }
  516. mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
  517. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  518. cmdBuilder := &exe.CmdBuilder{
  519. MakepkgBin: makepkgBin,
  520. SudoBin: "su",
  521. PacmanBin: pacmanBin,
  522. Runner: mockRunner,
  523. SudoLoopEnabled: false,
  524. }
  525. cmdBuilder.Runner = mockRunner
  526. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  527. parser.RebuildModeNo, false, NewTestLogger())
  528. cmdArgs := parser.MakeArguments()
  529. cmdArgs.AddArg("needed")
  530. cmdArgs.AddTarget("yay")
  531. pkgBuildDirs := map[string]string{
  532. "yay": tmpDir,
  533. }
  534. errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
  535. if tc.wantErrInstall {
  536. require.Error(td, errI)
  537. } else {
  538. require.NoError(td, errI)
  539. }
  540. err := installer.CompileFailedAndIgnored()
  541. if tc.wantErrCompile {
  542. require.Error(td, err)
  543. assert.ErrorContains(td, err, "yay")
  544. } else {
  545. require.NoError(td, err)
  546. }
  547. })
  548. }
  549. }
  550. func TestInstaller_InstallSplitPackage(t *testing.T) {
  551. t.Parallel()
  552. makepkgBin := t.TempDir() + "/makepkg"
  553. pacmanBin := t.TempDir() + "/pacman"
  554. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  555. require.NoError(t, err)
  556. require.NoError(t, f.Close())
  557. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  558. require.NoError(t, err)
  559. require.NoError(t, f.Close())
  560. type testCase struct {
  561. desc string
  562. wantShow []string
  563. wantCapture []string
  564. targets []map[string]*dep.InstallInfo
  565. }
  566. tmpDir := t.TempDir()
  567. testCases := []testCase{
  568. {
  569. desc: "jellyfin",
  570. targets: []map[string]*dep.InstallInfo{
  571. {"jellyfin": {
  572. Source: dep.AUR,
  573. Reason: dep.Explicit,
  574. Version: "10.8.4-1",
  575. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  576. AURBase: ptrString("jellyfin"),
  577. }},
  578. {
  579. "jellyfin-server": {
  580. Source: dep.AUR,
  581. Reason: dep.Dep,
  582. Version: "10.8.4-1",
  583. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  584. AURBase: ptrString("jellyfin"),
  585. },
  586. "jellyfin-web": {
  587. Source: dep.AUR,
  588. Reason: dep.Dep,
  589. Version: "10.8.4-1",
  590. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  591. AURBase: ptrString("jellyfin"),
  592. },
  593. },
  594. {
  595. "dotnet-runtime-6.0": {
  596. Source: dep.Sync,
  597. Reason: dep.Dep,
  598. Version: "6.0.12.sdk112-1",
  599. SyncDBName: ptrString("community"),
  600. },
  601. "aspnet-runtime": {
  602. Source: dep.Sync,
  603. Reason: dep.Dep,
  604. Version: "6.0.12.sdk112-1",
  605. SyncDBName: ptrString("community"),
  606. },
  607. "dotnet-sdk-6.0": {
  608. Source: dep.Sync,
  609. Reason: dep.MakeDep,
  610. Version: "6.0.12.sdk112-1",
  611. SyncDBName: ptrString("community"),
  612. },
  613. },
  614. },
  615. wantShow: []string{
  616. "pacman -S --config /etc/pacman.conf -- community/dotnet-runtime-6.0 community/aspnet-runtime community/dotnet-sdk-6.0",
  617. "pacman -D -q --asdeps --config /etc/pacman.conf -- dotnet-runtime-6.0 aspnet-runtime dotnet-sdk-6.0",
  618. "makepkg --nobuild -fC --ignorearch",
  619. "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
  620. "makepkg --nobuild -fC --ignorearch",
  621. "makepkg -c --nobuild --noextract --ignorearch",
  622. "pacman -U --config /etc/pacman.conf -- /testdir/jellyfin-web-10.8.4-1-x86_64.pkg.tar.zst /testdir/jellyfin-server-10.8.4-1-x86_64.pkg.tar.zst",
  623. "pacman -D -q --asdeps --config /etc/pacman.conf -- jellyfin-server jellyfin-web",
  624. "makepkg --nobuild -fC --ignorearch",
  625. "makepkg -c --nobuild --noextract --ignorearch",
  626. "pacman -U --config /etc/pacman.conf -- /testdir/jellyfin-10.8.4-1-x86_64.pkg.tar.zst",
  627. "pacman -D -q --asexplicit --config /etc/pacman.conf -- jellyfin",
  628. },
  629. wantCapture: []string{"makepkg --packagelist", "makepkg --packagelist", "makepkg --packagelist"},
  630. },
  631. }
  632. for _, tc := range testCases {
  633. tc := tc
  634. t.Run(tc.desc, func(td *testing.T) {
  635. pkgTars := []string{
  636. tmpDir + "/jellyfin-10.8.4-1-x86_64.pkg.tar.zst",
  637. tmpDir + "/jellyfin-web-10.8.4-1-x86_64.pkg.tar.zst",
  638. tmpDir + "/jellyfin-server-10.8.4-1-x86_64.pkg.tar.zst",
  639. }
  640. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  641. return strings.Join(pkgTars, "\n"), "", nil
  642. }
  643. i := 0
  644. showOverride := func(cmd *exec.Cmd) error {
  645. i++
  646. if i == 4 {
  647. for _, pkgTar := range pkgTars {
  648. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  649. require.NoError(td, err)
  650. require.NoError(td, f.Close())
  651. }
  652. }
  653. return nil
  654. }
  655. isCorrectInstalledOverride := func(string, string) bool {
  656. return false
  657. }
  658. mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
  659. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  660. cmdBuilder := &exe.CmdBuilder{
  661. MakepkgBin: makepkgBin,
  662. SudoBin: "su",
  663. PacmanBin: pacmanBin,
  664. PacmanConfigPath: "/etc/pacman.conf",
  665. Runner: mockRunner,
  666. SudoLoopEnabled: false,
  667. }
  668. cmdBuilder.Runner = mockRunner
  669. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  670. parser.RebuildModeNo, false, NewTestLogger())
  671. cmdArgs := parser.MakeArguments()
  672. cmdArgs.AddTarget("jellyfin")
  673. pkgBuildDirs := map[string]string{
  674. "jellyfin": tmpDir,
  675. }
  676. errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
  677. require.NoError(td, errI)
  678. require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
  679. require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
  680. for i, call := range mockRunner.ShowCalls {
  681. show := call.Args[0].(*exec.Cmd).String()
  682. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  683. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  684. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  685. // options are in a different order on different systems and on CI root user is used
  686. assert.Subset(td, strings.Split(show, " "),
  687. strings.Split(tc.wantShow[i], " "),
  688. fmt.Sprintf("got at %d: %s \n", i, show))
  689. }
  690. for i, call := range mockRunner.CaptureCalls {
  691. capture := call.Args[0].(*exec.Cmd).String()
  692. capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
  693. capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
  694. capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
  695. assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
  696. }
  697. })
  698. }
  699. }
  700. func TestInstaller_InstallDownloadOnly(t *testing.T) {
  701. t.Parallel()
  702. makepkgBin := t.TempDir() + "/makepkg"
  703. pacmanBin := t.TempDir() + "/pacman"
  704. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  705. require.NoError(t, err)
  706. require.NoError(t, f.Close())
  707. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  708. require.NoError(t, err)
  709. require.NoError(t, f.Close())
  710. type testCase struct {
  711. desc string
  712. isInstalled bool
  713. isBuilt bool
  714. wantShow []string
  715. wantCapture []string
  716. }
  717. testCases := []testCase{
  718. {
  719. desc: "not installed and not built",
  720. isInstalled: false,
  721. isBuilt: false,
  722. wantShow: []string{
  723. "makepkg --nobuild -fC --ignorearch",
  724. "makepkg -c --nobuild --noextract --ignorearch",
  725. },
  726. wantCapture: []string{"makepkg --packagelist"},
  727. },
  728. {
  729. desc: "not installed and built",
  730. isInstalled: false,
  731. isBuilt: true,
  732. wantShow: []string{
  733. "makepkg --nobuild -fC --ignorearch",
  734. "makepkg -c --nobuild --noextract --ignorearch",
  735. },
  736. wantCapture: []string{"makepkg --packagelist"},
  737. },
  738. {
  739. desc: "installed",
  740. isInstalled: true,
  741. isBuilt: false,
  742. wantShow: []string{
  743. "makepkg --nobuild -fC --ignorearch",
  744. "makepkg -c --nobuild --noextract --ignorearch",
  745. },
  746. wantCapture: []string{"makepkg --packagelist"},
  747. },
  748. }
  749. for _, tc := range testCases {
  750. tc := tc
  751. t.Run(tc.desc, func(td *testing.T) {
  752. tmpDir := td.TempDir()
  753. pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
  754. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  755. return pkgTar, "", nil
  756. }
  757. i := 0
  758. showOverride := func(cmd *exec.Cmd) error {
  759. i++
  760. if i == 2 {
  761. if !tc.isBuilt {
  762. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  763. require.NoError(td, err)
  764. require.NoError(td, f.Close())
  765. }
  766. }
  767. return nil
  768. }
  769. // create a mock file
  770. if tc.isBuilt {
  771. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  772. require.NoError(td, err)
  773. require.NoError(td, f.Close())
  774. }
  775. isCorrectInstalledOverride := func(string, string) bool {
  776. return tc.isInstalled
  777. }
  778. mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
  779. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  780. cmdBuilder := &exe.CmdBuilder{
  781. MakepkgBin: makepkgBin,
  782. SudoBin: "su",
  783. PacmanBin: pacmanBin,
  784. Runner: mockRunner,
  785. SudoLoopEnabled: false,
  786. }
  787. cmdBuilder.Runner = mockRunner
  788. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  789. parser.RebuildModeNo, true, NewTestLogger())
  790. cmdArgs := parser.MakeArguments()
  791. cmdArgs.AddTarget("yay")
  792. pkgBuildDirs := map[string]string{
  793. "yay": tmpDir,
  794. }
  795. targets := []map[string]*dep.InstallInfo{
  796. {
  797. "yay": {
  798. Source: dep.AUR,
  799. Reason: dep.Explicit,
  800. Version: "91.0.0-1",
  801. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  802. AURBase: ptrString("yay"),
  803. },
  804. },
  805. }
  806. errI := installer.Install(context.Background(), cmdArgs, targets, pkgBuildDirs, []string{}, false)
  807. require.NoError(td, errI)
  808. require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
  809. require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
  810. require.Empty(td, installer.failedAndIgnored)
  811. for i, call := range mockRunner.ShowCalls {
  812. show := call.Args[0].(*exec.Cmd).String()
  813. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  814. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  815. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  816. // options are in a different order on different systems and on CI root user is used
  817. assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
  818. }
  819. for i, call := range mockRunner.CaptureCalls {
  820. capture := call.Args[0].(*exec.Cmd).String()
  821. capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
  822. capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
  823. capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
  824. assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
  825. }
  826. })
  827. }
  828. }
  829. func TestInstaller_InstallGroup(t *testing.T) {
  830. t.Parallel()
  831. makepkgBin := t.TempDir() + "/makepkg"
  832. pacmanBin := t.TempDir() + "/pacman"
  833. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  834. require.NoError(t, err)
  835. require.NoError(t, f.Close())
  836. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  837. require.NoError(t, err)
  838. require.NoError(t, f.Close())
  839. type testCase struct {
  840. desc string
  841. wantShow []string
  842. wantCapture []string
  843. }
  844. testCases := []testCase{
  845. {
  846. desc: "group",
  847. wantShow: []string{
  848. "pacman -S --noconfirm --config -- community/kubernetes-tools",
  849. },
  850. wantCapture: []string{},
  851. },
  852. }
  853. for _, tc := range testCases {
  854. tc := tc
  855. t.Run(tc.desc, func(td *testing.T) {
  856. tmpDir := td.TempDir()
  857. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  858. return "", "", nil
  859. }
  860. showOverride := func(cmd *exec.Cmd) error {
  861. return nil
  862. }
  863. mockDB := &mock.DBExecutor{}
  864. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  865. cmdBuilder := &exe.CmdBuilder{
  866. MakepkgBin: makepkgBin,
  867. SudoBin: "su",
  868. PacmanBin: pacmanBin,
  869. Runner: mockRunner,
  870. SudoLoopEnabled: false,
  871. }
  872. cmdBuilder.Runner = mockRunner
  873. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  874. parser.RebuildModeNo, true, NewTestLogger())
  875. cmdArgs := parser.MakeArguments()
  876. cmdArgs.AddTarget("kubernetes-tools")
  877. pkgBuildDirs := map[string]string{}
  878. targets := []map[string]*dep.InstallInfo{
  879. {
  880. "kubernetes-tools": {
  881. Source: dep.Sync,
  882. Reason: dep.Explicit,
  883. Version: "",
  884. IsGroup: true,
  885. SyncDBName: ptrString("community"),
  886. },
  887. },
  888. }
  889. errI := installer.Install(context.Background(), cmdArgs, targets, pkgBuildDirs, []string{}, false)
  890. require.NoError(td, errI)
  891. require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
  892. require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
  893. require.Empty(td, installer.failedAndIgnored)
  894. for i, call := range mockRunner.ShowCalls {
  895. show := call.Args[0].(*exec.Cmd).String()
  896. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  897. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  898. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  899. // options are in a different order on different systems and on CI root user is used
  900. assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
  901. }
  902. for i, call := range mockRunner.CaptureCalls {
  903. capture := call.Args[0].(*exec.Cmd).String()
  904. capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
  905. capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
  906. capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
  907. assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
  908. }
  909. })
  910. }
  911. }
  912. func TestInstaller_InstallRebuild(t *testing.T) {
  913. t.Parallel()
  914. makepkgBin := t.TempDir() + "/makepkg"
  915. pacmanBin := t.TempDir() + "/pacman"
  916. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  917. require.NoError(t, err)
  918. require.NoError(t, f.Close())
  919. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  920. require.NoError(t, err)
  921. require.NoError(t, f.Close())
  922. type testCase struct {
  923. desc string
  924. rebuildOption parser.RebuildMode
  925. isInstalled bool
  926. isBuilt bool
  927. wantShow []string
  928. wantCapture []string
  929. targets []map[string]*dep.InstallInfo
  930. }
  931. tmpDir := t.TempDir()
  932. testCases := []testCase{
  933. {
  934. desc: "--norebuild(default) when built and not installed",
  935. rebuildOption: parser.RebuildModeNo,
  936. isBuilt: true,
  937. isInstalled: false,
  938. wantShow: []string{
  939. "makepkg --nobuild -fC --ignorearch",
  940. "makepkg -c --nobuild --noextract --ignorearch",
  941. "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  942. "pacman -D -q --asexplicit --config -- yay",
  943. },
  944. wantCapture: []string{"makepkg --packagelist"},
  945. targets: []map[string]*dep.InstallInfo{
  946. {
  947. "yay": {
  948. Source: dep.AUR,
  949. Reason: dep.Explicit,
  950. Version: "91.0.0-1",
  951. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  952. AURBase: ptrString("yay"),
  953. },
  954. },
  955. },
  956. },
  957. {
  958. desc: "--rebuild when built and not installed",
  959. rebuildOption: parser.RebuildModeYes,
  960. isBuilt: true,
  961. isInstalled: false,
  962. wantShow: []string{
  963. "makepkg --nobuild -fC --ignorearch",
  964. "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
  965. "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  966. "pacman -D -q --asexplicit --config -- yay",
  967. },
  968. wantCapture: []string{"makepkg --packagelist"},
  969. targets: []map[string]*dep.InstallInfo{
  970. {
  971. "yay": {
  972. Source: dep.AUR,
  973. Reason: dep.Explicit,
  974. Version: "91.0.0-1",
  975. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  976. AURBase: ptrString("yay"),
  977. },
  978. },
  979. },
  980. },
  981. {
  982. desc: "--rebuild when built and installed",
  983. rebuildOption: parser.RebuildModeYes,
  984. isInstalled: true,
  985. isBuilt: true,
  986. wantShow: []string{
  987. "makepkg --nobuild -fC --ignorearch",
  988. "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
  989. "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  990. "pacman -D -q --asexplicit --config -- yay",
  991. },
  992. wantCapture: []string{"makepkg --packagelist"},
  993. targets: []map[string]*dep.InstallInfo{
  994. {
  995. "yay": {
  996. Source: dep.AUR,
  997. Reason: dep.Explicit,
  998. Version: "91.0.0-1",
  999. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  1000. AURBase: ptrString("yay"),
  1001. },
  1002. },
  1003. },
  1004. },
  1005. {
  1006. desc: "--rebuild when built and installed previously as dep",
  1007. rebuildOption: parser.RebuildModeYes,
  1008. isInstalled: true,
  1009. isBuilt: true,
  1010. wantShow: []string{
  1011. "makepkg --nobuild -fC --ignorearch",
  1012. "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
  1013. "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  1014. "pacman -D -q --asdeps --config -- yay",
  1015. },
  1016. wantCapture: []string{"makepkg --packagelist"},
  1017. targets: []map[string]*dep.InstallInfo{
  1018. {
  1019. "yay": {
  1020. Source: dep.AUR,
  1021. Reason: dep.Dep,
  1022. Version: "91.0.0-1",
  1023. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  1024. AURBase: ptrString("yay"),
  1025. },
  1026. },
  1027. },
  1028. },
  1029. }
  1030. for _, tc := range testCases {
  1031. tc := tc
  1032. t.Run(tc.desc, func(td *testing.T) {
  1033. tmpDir := td.TempDir()
  1034. pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
  1035. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  1036. return pkgTar, "", nil
  1037. }
  1038. i := 0
  1039. showOverride := func(cmd *exec.Cmd) error {
  1040. i++
  1041. if i == 2 {
  1042. if !tc.isBuilt {
  1043. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  1044. require.NoError(td, err)
  1045. require.NoError(td, f.Close())
  1046. }
  1047. }
  1048. return nil
  1049. }
  1050. // create a mock file
  1051. if tc.isBuilt {
  1052. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  1053. require.NoError(td, err)
  1054. require.NoError(td, f.Close())
  1055. }
  1056. isCorrectInstalledOverride := func(string, string) bool {
  1057. return tc.isInstalled
  1058. }
  1059. mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
  1060. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  1061. cmdBuilder := &exe.CmdBuilder{
  1062. MakepkgBin: makepkgBin,
  1063. SudoBin: "su",
  1064. PacmanBin: pacmanBin,
  1065. Runner: mockRunner,
  1066. SudoLoopEnabled: false,
  1067. }
  1068. cmdBuilder.Runner = mockRunner
  1069. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  1070. tc.rebuildOption, false, NewTestLogger())
  1071. cmdArgs := parser.MakeArguments()
  1072. cmdArgs.AddTarget("yay")
  1073. pkgBuildDirs := map[string]string{
  1074. "yay": tmpDir,
  1075. }
  1076. errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
  1077. require.NoError(td, errI)
  1078. require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
  1079. require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
  1080. for i, call := range mockRunner.ShowCalls {
  1081. show := call.Args[0].(*exec.Cmd).String()
  1082. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  1083. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  1084. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  1085. // options are in a different order on different systems and on CI root user is used
  1086. assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
  1087. }
  1088. for i, call := range mockRunner.CaptureCalls {
  1089. capture := call.Args[0].(*exec.Cmd).String()
  1090. capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
  1091. capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
  1092. capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
  1093. assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
  1094. }
  1095. })
  1096. }
  1097. }
  1098. func TestInstaller_InstallUpgrade(t *testing.T) {
  1099. t.Parallel()
  1100. makepkgBin := t.TempDir() + "/makepkg"
  1101. pacmanBin := t.TempDir() + "/pacman"
  1102. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  1103. require.NoError(t, err)
  1104. require.NoError(t, f.Close())
  1105. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  1106. require.NoError(t, err)
  1107. require.NoError(t, f.Close())
  1108. type testCase struct {
  1109. desc string
  1110. targetMode parser.TargetMode
  1111. }
  1112. tmpDir := t.TempDir()
  1113. testCases := []testCase{
  1114. {
  1115. desc: "target any",
  1116. targetMode: parser.ModeAny,
  1117. },
  1118. {
  1119. desc: "target repo",
  1120. targetMode: parser.ModeRepo,
  1121. },
  1122. {
  1123. desc: "target aur",
  1124. targetMode: parser.ModeAUR,
  1125. },
  1126. }
  1127. for _, tc := range testCases {
  1128. tc := tc
  1129. t.Run(tc.desc, func(td *testing.T) {
  1130. mockDB := &mock.DBExecutor{}
  1131. mockRunner := &exe.MockRunner{}
  1132. cmdBuilder := &exe.CmdBuilder{
  1133. MakepkgBin: makepkgBin,
  1134. SudoBin: "su",
  1135. PacmanBin: pacmanBin,
  1136. Runner: mockRunner,
  1137. SudoLoopEnabled: false,
  1138. }
  1139. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, tc.targetMode,
  1140. parser.RebuildModeNo, false, NewTestLogger())
  1141. cmdArgs := parser.MakeArguments()
  1142. cmdArgs.AddArg("u", "upgrades") // Make sure both args are removed
  1143. targets := []map[string]*dep.InstallInfo{
  1144. {
  1145. "linux": {
  1146. Source: dep.Sync,
  1147. Reason: dep.Dep,
  1148. Version: "17.0.0-1",
  1149. SyncDBName: ptrString("core"),
  1150. },
  1151. },
  1152. }
  1153. errI := installer.Install(context.Background(), cmdArgs, targets, map[string]string{}, []string{}, false)
  1154. require.NoError(td, errI)
  1155. require.NotEmpty(td, mockRunner.ShowCalls)
  1156. // The first call is the only call being test
  1157. call := mockRunner.ShowCalls[0]
  1158. show := call.Args[0].(*exec.Cmd).String()
  1159. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  1160. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  1161. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  1162. if tc.targetMode == parser.ModeAUR {
  1163. assert.NotContains(td, show, "--upgrades")
  1164. assert.NotContains(td, show, "-u")
  1165. } else {
  1166. assert.Contains(td, show, "--upgrades")
  1167. assert.Contains(td, show, "-u")
  1168. }
  1169. })
  1170. }
  1171. }