12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250 |
- package main
- import (
- "context"
- "errors"
- "fmt"
- "io"
- "os"
- "os/exec"
- "strings"
- "testing"
- "github.com/stretchr/testify/assert"
- "github.com/stretchr/testify/require"
- "github.com/Jguer/yay/v12/pkg/db/mock"
- "github.com/Jguer/yay/v12/pkg/dep"
- "github.com/Jguer/yay/v12/pkg/settings/exe"
- "github.com/Jguer/yay/v12/pkg/settings/parser"
- "github.com/Jguer/yay/v12/pkg/text"
- "github.com/Jguer/yay/v12/pkg/vcs"
- )
- func NewTestLogger() *text.Logger {
- return text.NewLogger(io.Discard, io.Discard, strings.NewReader(""), true, "test")
- }
- func ptrString(s string) *string {
- return &s
- }
- func TestInstaller_InstallNeeded(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- isInstalled bool
- isBuilt bool
- wantShow []string
- wantCapture []string
- }
- testCases := []testCase{
- {
- desc: "not installed and not built",
- isInstalled: false,
- isBuilt: false,
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --needed --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- },
- {
- desc: "not installed and built",
- isInstalled: false,
- isBuilt: true,
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- "pacman -U --needed --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- },
- {
- desc: "installed",
- isInstalled: true,
- isBuilt: false,
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- },
- wantCapture: []string{"makepkg --packagelist"},
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- tmpDir := td.TempDir()
- pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- return pkgTar, "", nil
- }
- i := 0
- showOverride := func(cmd *exec.Cmd) error {
- i++
- if i == 2 {
- if !tc.isBuilt {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- }
- return nil
- }
- // create a mock file
- if tc.isBuilt {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- isCorrectInstalledOverride := func(string, string) bool {
- return tc.isInstalled
- }
- mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- parser.RebuildModeNo, false, NewTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddArg("needed")
- cmdArgs.AddTarget("yay")
- pkgBuildDirs := map[string]string{
- "yay": tmpDir,
- }
- targets := []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- }
- errI := installer.Install(context.Background(), cmdArgs, targets, pkgBuildDirs, []string{}, false)
- require.NoError(td, errI)
- require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
- require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
- for i, call := range mockRunner.ShowCalls {
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- // options are in a different order on different systems and on CI root user is used
- assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
- }
- for i, call := range mockRunner.CaptureCalls {
- capture := call.Args[0].(*exec.Cmd).String()
- capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
- capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
- capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
- assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
- }
- })
- }
- }
- func TestInstaller_InstallMixedSourcesAndLayers(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- targets []map[string]*dep.InstallInfo
- wantShow []string
- wantCapture []string
- }
- tmpDir := t.TempDir()
- tmpDirJfin := t.TempDir()
- testCases := []testCase{
- {
- desc: "same layer -- different sources",
- wantShow: []string{
- "pacman -S --config /etc/pacman.conf -- core/linux",
- "pacman -D -q --asdeps --config /etc/pacman.conf -- linux",
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- "linux": {
- Source: dep.Sync,
- Reason: dep.Dep,
- Version: "17.0.0-1",
- SyncDBName: ptrString("core"),
- },
- },
- },
- },
- {
- desc: "different layer -- different sources",
- wantShow: []string{
- "pacman -S --config /etc/pacman.conf -- core/linux",
- "pacman -D -q --asdeps --config /etc/pacman.conf -- linux",
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- }, {
- "linux": {
- Source: dep.Sync,
- Reason: dep.Dep,
- Version: "17.0.0-1",
- SyncDBName: ptrString("core"),
- },
- },
- },
- },
- {
- desc: "same layer -- sync",
- wantShow: []string{
- "pacman -S --config /etc/pacman.conf -- extra/linux-zen core/linux",
- "pacman -D -q --asexplicit --config /etc/pacman.conf -- linux-zen linux",
- },
- wantCapture: []string{},
- targets: []map[string]*dep.InstallInfo{
- {
- "linux-zen": {
- Source: dep.Sync,
- Reason: dep.Explicit,
- Version: "18.0.0-1",
- SyncDBName: ptrString("extra"),
- },
- "linux": {
- Source: dep.Sync,
- Reason: dep.Explicit,
- Version: "17.0.0-1",
- SyncDBName: ptrString("core"),
- },
- },
- },
- },
- {
- desc: "same layer -- aur",
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config /etc/pacman.conf -- pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
- },
- wantCapture: []string{"makepkg --packagelist", "makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- "jellyfin-server": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "10.8.8-1",
- SrcinfoPath: ptrString(tmpDirJfin + "/.SRCINFO"),
- AURBase: ptrString("jellyfin"),
- },
- },
- },
- },
- {
- desc: "different layer -- aur",
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config /etc/pacman.conf -- pacman -U --config /etc/pacman.conf -- /testdir/jellyfin-server-10.8.8-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asdeps --config /etc/pacman.conf -- jellyfin-server",
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config /etc/pacman.conf -- pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
- },
- wantCapture: []string{"makepkg --packagelist", "makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- }, {
- "jellyfin-server": {
- Source: dep.AUR,
- Reason: dep.MakeDep,
- Version: "10.8.8-1",
- SrcinfoPath: ptrString(tmpDirJfin + "/.SRCINFO"),
- AURBase: ptrString("jellyfin"),
- },
- },
- },
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
- jfinPkgTar := tmpDirJfin + "/jellyfin-server-10.8.8-1-x86_64.pkg.tar.zst"
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- if cmd.Dir == tmpDirJfin {
- return jfinPkgTar, "", nil
- }
- if cmd.Dir == tmpDir {
- return pkgTar, "", nil
- }
- return "", "", fmt.Errorf("unexpected command: %s - %s", cmd.String(), cmd.Dir)
- }
- showOverride := func(cmd *exec.Cmd) error {
- if strings.Contains(cmd.String(), "makepkg -cf --noconfirm") && cmd.Dir == tmpDir {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- if strings.Contains(cmd.String(), "makepkg -cf --noconfirm") && cmd.Dir == tmpDirJfin {
- f, err := os.OpenFile(jfinPkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- return nil
- }
- defer os.Remove(pkgTar)
- defer os.Remove(jfinPkgTar)
- isCorrectInstalledOverride := func(string, string) bool {
- return false
- }
- mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- PacmanConfigPath: "/etc/pacman.conf",
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny, parser.RebuildModeNo, false, NewTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddTarget("yay")
- pkgBuildDirs := map[string]string{
- "yay": tmpDir,
- "jellyfin": tmpDirJfin,
- }
- errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
- require.NoError(td, errI)
- require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
- require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
- for i, call := range mockRunner.ShowCalls {
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, tmpDirJfin, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- // options are in a different order on different systems and on CI root user is used
- assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
- }
- for i, call := range mockRunner.CaptureCalls {
- capture := call.Args[0].(*exec.Cmd).String()
- capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
- capture = strings.ReplaceAll(capture, tmpDirJfin, "/testdir")
- capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
- capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
- assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
- }
- })
- }
- }
- func TestInstaller_RunPostHooks(t *testing.T) {
- mockDB := &mock.DBExecutor{}
- mockRunner := &exe.MockRunner{}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: "makepkg",
- SudoBin: "su",
- PacmanBin: "pacman",
- PacmanConfigPath: "/etc/pacman.conf",
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- parser.RebuildModeNo, false, NewTestLogger())
- called := false
- hook := func(ctx context.Context) error {
- called = true
- return nil
- }
- installer.AddPostInstallHook(hook)
- installer.RunPostInstallHooks(context.Background())
- assert.True(t, called)
- }
- func TestInstaller_CompileFailed(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- targets []map[string]*dep.InstallInfo
- wantErrInstall bool
- wantErrCompile bool
- failBuild bool
- failPkgInstall bool
- }
- tmpDir := t.TempDir()
- testCases := []testCase{
- {
- desc: "one layer",
- wantErrInstall: false,
- wantErrCompile: true,
- failBuild: true,
- failPkgInstall: false,
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- {
- desc: "one layer -- fail install",
- wantErrInstall: true,
- wantErrCompile: false,
- failBuild: false,
- failPkgInstall: true,
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- {
- desc: "two layers",
- wantErrInstall: false,
- wantErrCompile: true,
- failBuild: true,
- failPkgInstall: false,
- targets: []map[string]*dep.InstallInfo{
- {"bob": {
- AURBase: ptrString("yay"),
- }},
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- return pkgTar, "", nil
- }
- showOverride := func(cmd *exec.Cmd) error {
- if tc.failBuild && strings.Contains(cmd.String(), "makepkg -cf --noconfirm") && cmd.Dir == tmpDir {
- return errors.New("makepkg failed")
- }
- return nil
- }
- isCorrectInstalledOverride := func(string, string) bool {
- return false
- }
- mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- parser.RebuildModeNo, false, NewTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddArg("needed")
- cmdArgs.AddTarget("yay")
- pkgBuildDirs := map[string]string{
- "yay": tmpDir,
- }
- errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
- if tc.wantErrInstall {
- require.Error(td, errI)
- } else {
- require.NoError(td, errI)
- }
- err := installer.CompileFailedAndIgnored()
- if tc.wantErrCompile {
- require.Error(td, err)
- assert.ErrorContains(td, err, "yay")
- } else {
- require.NoError(td, err)
- }
- })
- }
- }
- func TestInstaller_InstallSplitPackage(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- wantShow []string
- wantCapture []string
- targets []map[string]*dep.InstallInfo
- }
- tmpDir := t.TempDir()
- testCases := []testCase{
- {
- desc: "jellyfin",
- targets: []map[string]*dep.InstallInfo{
- {"jellyfin": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "10.8.4-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("jellyfin"),
- }},
- {
- "jellyfin-server": {
- Source: dep.AUR,
- Reason: dep.Dep,
- Version: "10.8.4-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("jellyfin"),
- },
- "jellyfin-web": {
- Source: dep.AUR,
- Reason: dep.Dep,
- Version: "10.8.4-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("jellyfin"),
- },
- },
- {
- "dotnet-runtime-6.0": {
- Source: dep.Sync,
- Reason: dep.Dep,
- Version: "6.0.12.sdk112-1",
- SyncDBName: ptrString("community"),
- },
- "aspnet-runtime": {
- Source: dep.Sync,
- Reason: dep.Dep,
- Version: "6.0.12.sdk112-1",
- SyncDBName: ptrString("community"),
- },
- "dotnet-sdk-6.0": {
- Source: dep.Sync,
- Reason: dep.MakeDep,
- Version: "6.0.12.sdk112-1",
- SyncDBName: ptrString("community"),
- },
- },
- },
- wantShow: []string{
- "pacman -S --config /etc/pacman.conf -- community/dotnet-runtime-6.0 community/aspnet-runtime community/dotnet-sdk-6.0",
- "pacman -D -q --asdeps --config /etc/pacman.conf -- dotnet-runtime-6.0 aspnet-runtime dotnet-sdk-6.0",
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- "pacman -U --config /etc/pacman.conf -- /testdir/jellyfin-web-10.8.4-1-x86_64.pkg.tar.zst /testdir/jellyfin-server-10.8.4-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asdeps --config /etc/pacman.conf -- jellyfin-server jellyfin-web",
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- "pacman -U --config /etc/pacman.conf -- /testdir/jellyfin-10.8.4-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config /etc/pacman.conf -- jellyfin",
- },
- wantCapture: []string{"makepkg --packagelist", "makepkg --packagelist", "makepkg --packagelist"},
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- pkgTars := []string{
- tmpDir + "/jellyfin-10.8.4-1-x86_64.pkg.tar.zst",
- tmpDir + "/jellyfin-web-10.8.4-1-x86_64.pkg.tar.zst",
- tmpDir + "/jellyfin-server-10.8.4-1-x86_64.pkg.tar.zst",
- }
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- return strings.Join(pkgTars, "\n"), "", nil
- }
- i := 0
- showOverride := func(cmd *exec.Cmd) error {
- i++
- if i == 4 {
- for _, pkgTar := range pkgTars {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- }
- return nil
- }
- isCorrectInstalledOverride := func(string, string) bool {
- return false
- }
- mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- PacmanConfigPath: "/etc/pacman.conf",
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- parser.RebuildModeNo, false, NewTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddTarget("jellyfin")
- pkgBuildDirs := map[string]string{
- "jellyfin": tmpDir,
- }
- errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
- require.NoError(td, errI)
- require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
- require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
- for i, call := range mockRunner.ShowCalls {
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- // options are in a different order on different systems and on CI root user is used
- assert.Subset(td, strings.Split(show, " "),
- strings.Split(tc.wantShow[i], " "),
- fmt.Sprintf("got at %d: %s \n", i, show))
- }
- for i, call := range mockRunner.CaptureCalls {
- capture := call.Args[0].(*exec.Cmd).String()
- capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
- capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
- capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
- assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
- }
- })
- }
- }
- func TestInstaller_InstallDownloadOnly(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- isInstalled bool
- isBuilt bool
- wantShow []string
- wantCapture []string
- }
- testCases := []testCase{
- {
- desc: "not installed and not built",
- isInstalled: false,
- isBuilt: false,
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- },
- wantCapture: []string{"makepkg --packagelist"},
- },
- {
- desc: "not installed and built",
- isInstalled: false,
- isBuilt: true,
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- },
- wantCapture: []string{"makepkg --packagelist"},
- },
- {
- desc: "installed",
- isInstalled: true,
- isBuilt: false,
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- },
- wantCapture: []string{"makepkg --packagelist"},
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- tmpDir := td.TempDir()
- pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- return pkgTar, "", nil
- }
- i := 0
- showOverride := func(cmd *exec.Cmd) error {
- i++
- if i == 2 {
- if !tc.isBuilt {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- }
- return nil
- }
- // create a mock file
- if tc.isBuilt {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- isCorrectInstalledOverride := func(string, string) bool {
- return tc.isInstalled
- }
- mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- parser.RebuildModeNo, true, NewTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddTarget("yay")
- pkgBuildDirs := map[string]string{
- "yay": tmpDir,
- }
- targets := []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- }
- errI := installer.Install(context.Background(), cmdArgs, targets, pkgBuildDirs, []string{}, false)
- require.NoError(td, errI)
- require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
- require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
- require.Empty(td, installer.failedAndIgnored)
- for i, call := range mockRunner.ShowCalls {
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- // options are in a different order on different systems and on CI root user is used
- assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
- }
- for i, call := range mockRunner.CaptureCalls {
- capture := call.Args[0].(*exec.Cmd).String()
- capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
- capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
- capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
- assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
- }
- })
- }
- }
- func TestInstaller_InstallGroup(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- wantShow []string
- wantCapture []string
- }
- testCases := []testCase{
- {
- desc: "group",
- wantShow: []string{
- "pacman -S --noconfirm --config -- community/kubernetes-tools",
- },
- wantCapture: []string{},
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- tmpDir := td.TempDir()
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- return "", "", nil
- }
- showOverride := func(cmd *exec.Cmd) error {
- return nil
- }
- mockDB := &mock.DBExecutor{}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- parser.RebuildModeNo, true, NewTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddTarget("kubernetes-tools")
- pkgBuildDirs := map[string]string{}
- targets := []map[string]*dep.InstallInfo{
- {
- "kubernetes-tools": {
- Source: dep.Sync,
- Reason: dep.Explicit,
- Version: "",
- IsGroup: true,
- SyncDBName: ptrString("community"),
- },
- },
- }
- errI := installer.Install(context.Background(), cmdArgs, targets, pkgBuildDirs, []string{}, false)
- require.NoError(td, errI)
- require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
- require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
- require.Empty(td, installer.failedAndIgnored)
- for i, call := range mockRunner.ShowCalls {
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- // options are in a different order on different systems and on CI root user is used
- assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
- }
- for i, call := range mockRunner.CaptureCalls {
- capture := call.Args[0].(*exec.Cmd).String()
- capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
- capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
- capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
- assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
- }
- })
- }
- }
- func TestInstaller_InstallRebuild(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- rebuildOption parser.RebuildMode
- isInstalled bool
- isBuilt bool
- wantShow []string
- wantCapture []string
- targets []map[string]*dep.InstallInfo
- }
- tmpDir := t.TempDir()
- testCases := []testCase{
- {
- desc: "--norebuild(default) when built and not installed",
- rebuildOption: parser.RebuildModeNo,
- isBuilt: true,
- isInstalled: false,
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- {
- desc: "--rebuild when built and not installed",
- rebuildOption: parser.RebuildModeYes,
- isBuilt: true,
- isInstalled: false,
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- {
- desc: "--rebuild when built and installed",
- rebuildOption: parser.RebuildModeYes,
- isInstalled: true,
- isBuilt: true,
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- {
- desc: "--rebuild when built and installed previously as dep",
- rebuildOption: parser.RebuildModeYes,
- isInstalled: true,
- isBuilt: true,
- wantShow: []string{
- "makepkg --nobuild -fC --ignorearch",
- "makepkg -cf --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asdeps --config -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Dep,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- tmpDir := td.TempDir()
- pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- return pkgTar, "", nil
- }
- i := 0
- showOverride := func(cmd *exec.Cmd) error {
- i++
- if i == 2 {
- if !tc.isBuilt {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- }
- return nil
- }
- // create a mock file
- if tc.isBuilt {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- isCorrectInstalledOverride := func(string, string) bool {
- return tc.isInstalled
- }
- mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- tc.rebuildOption, false, NewTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddTarget("yay")
- pkgBuildDirs := map[string]string{
- "yay": tmpDir,
- }
- errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
- require.NoError(td, errI)
- require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
- require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
- for i, call := range mockRunner.ShowCalls {
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- // options are in a different order on different systems and on CI root user is used
- assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
- }
- for i, call := range mockRunner.CaptureCalls {
- capture := call.Args[0].(*exec.Cmd).String()
- capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
- capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
- capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
- assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
- }
- })
- }
- }
|