installer_test.go 42 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441
  1. package build
  2. import (
  3. "context"
  4. "errors"
  5. "fmt"
  6. "io"
  7. "os"
  8. "os/exec"
  9. "strings"
  10. "testing"
  11. "github.com/stretchr/testify/assert"
  12. "github.com/stretchr/testify/require"
  13. "github.com/Jguer/yay/v12/pkg/db/mock"
  14. "github.com/Jguer/yay/v12/pkg/dep"
  15. "github.com/Jguer/yay/v12/pkg/settings/exe"
  16. "github.com/Jguer/yay/v12/pkg/settings/parser"
  17. "github.com/Jguer/yay/v12/pkg/text"
  18. "github.com/Jguer/yay/v12/pkg/vcs"
  19. )
  20. func newTestLogger() *text.Logger {
  21. return text.NewLogger(io.Discard, io.Discard, strings.NewReader(""), true, "test")
  22. }
  23. func ptrString(s string) *string {
  24. return &s
  25. }
  26. func TestInstaller_InstallNeeded(t *testing.T) {
  27. t.Parallel()
  28. makepkgBin := t.TempDir() + "/makepkg"
  29. pacmanBin := t.TempDir() + "/pacman"
  30. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  31. require.NoError(t, err)
  32. require.NoError(t, f.Close())
  33. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  34. require.NoError(t, err)
  35. require.NoError(t, f.Close())
  36. type testCase struct {
  37. desc string
  38. isInstalled bool
  39. isBuilt bool
  40. wantShow []string
  41. wantCapture []string
  42. }
  43. testCases := []testCase{
  44. {
  45. desc: "not installed and not built",
  46. isInstalled: false,
  47. isBuilt: false,
  48. wantShow: []string{
  49. "makepkg --nobuild -f -C --ignorearch",
  50. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  51. "pacman -U --needed --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  52. "pacman -D -q --asexplicit --config -- yay",
  53. },
  54. wantCapture: []string{"makepkg --packagelist"},
  55. },
  56. {
  57. desc: "not installed and built",
  58. isInstalled: false,
  59. isBuilt: true,
  60. wantShow: []string{
  61. "makepkg --nobuild -f -C --ignorearch",
  62. "makepkg -c --nobuild --noextract --ignorearch",
  63. "pacman -U --needed --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  64. "pacman -D -q --asexplicit --config -- yay",
  65. },
  66. wantCapture: []string{"makepkg --packagelist"},
  67. },
  68. {
  69. desc: "installed",
  70. isInstalled: true,
  71. isBuilt: false,
  72. wantShow: []string{
  73. "makepkg --nobuild -f -C --ignorearch",
  74. "makepkg -c --nobuild --noextract --ignorearch",
  75. },
  76. wantCapture: []string{"makepkg --packagelist"},
  77. },
  78. }
  79. for _, tc := range testCases {
  80. tc := tc
  81. t.Run(tc.desc, func(td *testing.T) {
  82. tmpDir := td.TempDir()
  83. pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
  84. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  85. return pkgTar, "", nil
  86. }
  87. i := 0
  88. showOverride := func(cmd *exec.Cmd) error {
  89. i++
  90. if i == 2 {
  91. if !tc.isBuilt {
  92. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  93. require.NoError(td, err)
  94. require.NoError(td, f.Close())
  95. }
  96. }
  97. return nil
  98. }
  99. // create a mock file
  100. if tc.isBuilt {
  101. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  102. require.NoError(td, err)
  103. require.NoError(td, f.Close())
  104. }
  105. isCorrectInstalledOverride := func(string, string) bool {
  106. return tc.isInstalled
  107. }
  108. mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
  109. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  110. cmdBuilder := &exe.CmdBuilder{
  111. MakepkgBin: makepkgBin,
  112. SudoBin: "su",
  113. PacmanBin: pacmanBin,
  114. Runner: mockRunner,
  115. SudoLoopEnabled: false,
  116. }
  117. cmdBuilder.Runner = mockRunner
  118. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  119. parser.RebuildModeNo, false, newTestLogger())
  120. cmdArgs := parser.MakeArguments()
  121. cmdArgs.AddArg("needed")
  122. cmdArgs.AddTarget("yay")
  123. pkgBuildDirs := map[string]string{
  124. "yay": tmpDir,
  125. }
  126. targets := []map[string]*dep.InstallInfo{
  127. {
  128. "yay": {
  129. Source: dep.AUR,
  130. Reason: dep.Explicit,
  131. Version: "91.0.0-1",
  132. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  133. AURBase: ptrString("yay"),
  134. },
  135. },
  136. }
  137. errI := installer.Install(context.Background(), cmdArgs, targets, pkgBuildDirs, []string{}, false)
  138. require.NoError(td, errI)
  139. require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
  140. require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
  141. for i, call := range mockRunner.ShowCalls {
  142. show := call.Args[0].(*exec.Cmd).String()
  143. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  144. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  145. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  146. // options are in a different order on different systems and on CI root user is used
  147. assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
  148. }
  149. for i, call := range mockRunner.CaptureCalls {
  150. capture := call.Args[0].(*exec.Cmd).String()
  151. capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
  152. capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
  153. capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
  154. assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
  155. }
  156. })
  157. }
  158. }
  159. func TestInstaller_InstallMixedSourcesAndLayers(t *testing.T) {
  160. t.Parallel()
  161. makepkgBin := t.TempDir() + "/makepkg"
  162. pacmanBin := t.TempDir() + "/pacman"
  163. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  164. require.NoError(t, err)
  165. require.NoError(t, f.Close())
  166. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  167. require.NoError(t, err)
  168. require.NoError(t, f.Close())
  169. type testCase struct {
  170. desc string
  171. targets []map[string]*dep.InstallInfo
  172. wantShow []string
  173. wantCapture []string
  174. }
  175. tmpDir := t.TempDir()
  176. tmpDirJfin := t.TempDir()
  177. testCases := []testCase{
  178. {
  179. desc: "same layer -- different sources",
  180. wantShow: []string{
  181. "pacman -S --config /etc/pacman.conf -- core/linux",
  182. "pacman -D -q --asdeps --config /etc/pacman.conf -- linux",
  183. "makepkg --nobuild -f -C --ignorearch",
  184. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  185. "pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  186. "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
  187. },
  188. wantCapture: []string{"makepkg --packagelist"},
  189. targets: []map[string]*dep.InstallInfo{
  190. {
  191. "yay": {
  192. Source: dep.AUR,
  193. Reason: dep.Explicit,
  194. Version: "91.0.0-1",
  195. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  196. AURBase: ptrString("yay"),
  197. },
  198. "linux": {
  199. Source: dep.Sync,
  200. Reason: dep.Dep,
  201. Version: "17.0.0-1",
  202. SyncDBName: ptrString("core"),
  203. },
  204. },
  205. },
  206. },
  207. {
  208. desc: "different layer -- different sources",
  209. wantShow: []string{
  210. "pacman -S --config /etc/pacman.conf -- core/linux",
  211. "pacman -D -q --asdeps --config /etc/pacman.conf -- linux",
  212. "makepkg --nobuild -f -C --ignorearch",
  213. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  214. "pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  215. "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
  216. },
  217. wantCapture: []string{"makepkg --packagelist"},
  218. targets: []map[string]*dep.InstallInfo{
  219. {
  220. "yay": {
  221. Source: dep.AUR,
  222. Reason: dep.Explicit,
  223. Version: "91.0.0-1",
  224. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  225. AURBase: ptrString("yay"),
  226. },
  227. }, {
  228. "linux": {
  229. Source: dep.Sync,
  230. Reason: dep.Dep,
  231. Version: "17.0.0-1",
  232. SyncDBName: ptrString("core"),
  233. },
  234. },
  235. },
  236. },
  237. {
  238. desc: "same layer -- sync",
  239. wantShow: []string{
  240. "pacman -S --config /etc/pacman.conf -- extra/linux-zen core/linux",
  241. "pacman -D -q --asexplicit --config /etc/pacman.conf -- linux-zen linux",
  242. },
  243. wantCapture: []string{},
  244. targets: []map[string]*dep.InstallInfo{
  245. {
  246. "linux-zen": {
  247. Source: dep.Sync,
  248. Reason: dep.Explicit,
  249. Version: "18.0.0-1",
  250. SyncDBName: ptrString("extra"),
  251. },
  252. "linux": {
  253. Source: dep.Sync,
  254. Reason: dep.Explicit,
  255. Version: "17.0.0-1",
  256. SyncDBName: ptrString("core"),
  257. },
  258. },
  259. },
  260. },
  261. {
  262. desc: "same layer -- aur",
  263. wantShow: []string{
  264. "makepkg --nobuild -f -C --ignorearch",
  265. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  266. "makepkg --nobuild -f -C --ignorearch",
  267. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  268. "pacman -U --config /etc/pacman.conf -- pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  269. "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
  270. },
  271. wantCapture: []string{"makepkg --packagelist", "makepkg --packagelist"},
  272. targets: []map[string]*dep.InstallInfo{
  273. {
  274. "yay": {
  275. Source: dep.AUR,
  276. Reason: dep.Explicit,
  277. Version: "91.0.0-1",
  278. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  279. AURBase: ptrString("yay"),
  280. },
  281. "jellyfin-server": {
  282. Source: dep.AUR,
  283. Reason: dep.Explicit,
  284. Version: "10.8.8-1",
  285. SrcinfoPath: ptrString(tmpDirJfin + "/.SRCINFO"),
  286. AURBase: ptrString("jellyfin"),
  287. },
  288. },
  289. },
  290. },
  291. {
  292. desc: "different layer -- aur",
  293. wantShow: []string{
  294. "makepkg --nobuild -f -C --ignorearch",
  295. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  296. "pacman -U --config /etc/pacman.conf -- pacman -U --config /etc/pacman.conf -- /testdir/jellyfin-server-10.8.8-1-x86_64.pkg.tar.zst",
  297. "pacman -D -q --asdeps --config /etc/pacman.conf -- jellyfin-server",
  298. "makepkg --nobuild -f -C --ignorearch",
  299. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  300. "pacman -U --config /etc/pacman.conf -- pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  301. "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
  302. },
  303. wantCapture: []string{"makepkg --packagelist", "makepkg --packagelist"},
  304. targets: []map[string]*dep.InstallInfo{
  305. {
  306. "yay": {
  307. Source: dep.AUR,
  308. Reason: dep.Explicit,
  309. Version: "91.0.0-1",
  310. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  311. AURBase: ptrString("yay"),
  312. },
  313. }, {
  314. "jellyfin-server": {
  315. Source: dep.AUR,
  316. Reason: dep.MakeDep,
  317. Version: "10.8.8-1",
  318. SrcinfoPath: ptrString(tmpDirJfin + "/.SRCINFO"),
  319. AURBase: ptrString("jellyfin"),
  320. },
  321. },
  322. },
  323. },
  324. }
  325. for _, tc := range testCases {
  326. tc := tc
  327. t.Run(tc.desc, func(td *testing.T) {
  328. pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
  329. jfinPkgTar := tmpDirJfin + "/jellyfin-server-10.8.8-1-x86_64.pkg.tar.zst"
  330. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  331. if cmd.Dir == tmpDirJfin {
  332. return jfinPkgTar, "", nil
  333. }
  334. if cmd.Dir == tmpDir {
  335. return pkgTar, "", nil
  336. }
  337. return "", "", fmt.Errorf("unexpected command: %s - %s", cmd.String(), cmd.Dir)
  338. }
  339. showOverride := func(cmd *exec.Cmd) error {
  340. if strings.Contains(cmd.String(), "makepkg -f --noconfirm") && cmd.Dir == tmpDir {
  341. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  342. require.NoError(td, err)
  343. require.NoError(td, f.Close())
  344. }
  345. if strings.Contains(cmd.String(), "makepkg -f --noconfirm") && cmd.Dir == tmpDirJfin {
  346. f, err := os.OpenFile(jfinPkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  347. require.NoError(td, err)
  348. require.NoError(td, f.Close())
  349. }
  350. return nil
  351. }
  352. defer os.Remove(pkgTar)
  353. defer os.Remove(jfinPkgTar)
  354. isCorrectInstalledOverride := func(string, string) bool {
  355. return false
  356. }
  357. mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
  358. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  359. cmdBuilder := &exe.CmdBuilder{
  360. MakepkgBin: makepkgBin,
  361. SudoBin: "su",
  362. PacmanBin: pacmanBin,
  363. PacmanConfigPath: "/etc/pacman.conf",
  364. Runner: mockRunner,
  365. SudoLoopEnabled: false,
  366. }
  367. cmdBuilder.Runner = mockRunner
  368. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny, parser.RebuildModeNo, false, newTestLogger())
  369. cmdArgs := parser.MakeArguments()
  370. cmdArgs.AddTarget("yay")
  371. pkgBuildDirs := map[string]string{
  372. "yay": tmpDir,
  373. "jellyfin": tmpDirJfin,
  374. }
  375. errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
  376. require.NoError(td, errI)
  377. require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
  378. require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
  379. for i, call := range mockRunner.ShowCalls {
  380. show := call.Args[0].(*exec.Cmd).String()
  381. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  382. show = strings.ReplaceAll(show, tmpDirJfin, "/testdir") // replace the temp dir with a static path
  383. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  384. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  385. // options are in a different order on different systems and on CI root user is used
  386. assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
  387. }
  388. for i, call := range mockRunner.CaptureCalls {
  389. capture := call.Args[0].(*exec.Cmd).String()
  390. capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
  391. capture = strings.ReplaceAll(capture, tmpDirJfin, "/testdir")
  392. capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
  393. capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
  394. assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
  395. }
  396. })
  397. }
  398. }
  399. func TestInstaller_RunPostHooks(t *testing.T) {
  400. mockDB := &mock.DBExecutor{}
  401. mockRunner := &exe.MockRunner{}
  402. cmdBuilder := &exe.CmdBuilder{
  403. MakepkgBin: "makepkg",
  404. SudoBin: "su",
  405. PacmanBin: "pacman",
  406. PacmanConfigPath: "/etc/pacman.conf",
  407. Runner: mockRunner,
  408. SudoLoopEnabled: false,
  409. }
  410. cmdBuilder.Runner = mockRunner
  411. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  412. parser.RebuildModeNo, false, newTestLogger())
  413. called := false
  414. hook := func(ctx context.Context) error {
  415. called = true
  416. return nil
  417. }
  418. installer.AddPostInstallHook(hook)
  419. installer.RunPostInstallHooks(context.Background())
  420. assert.True(t, called)
  421. }
  422. func TestInstaller_CompileFailed(t *testing.T) {
  423. t.Parallel()
  424. makepkgBin := t.TempDir() + "/makepkg"
  425. pacmanBin := t.TempDir() + "/pacman"
  426. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  427. require.NoError(t, err)
  428. require.NoError(t, f.Close())
  429. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  430. require.NoError(t, err)
  431. require.NoError(t, f.Close())
  432. type testCase struct {
  433. desc string
  434. targets []map[string]*dep.InstallInfo
  435. wantErrInstall bool
  436. wantErrCompile bool
  437. failBuild bool
  438. failPkgInstall bool
  439. }
  440. tmpDir := t.TempDir()
  441. testCases := []testCase{
  442. {
  443. desc: "one layer",
  444. wantErrInstall: false,
  445. wantErrCompile: true,
  446. failBuild: true,
  447. failPkgInstall: false,
  448. targets: []map[string]*dep.InstallInfo{
  449. {
  450. "yay": {
  451. Source: dep.AUR,
  452. Reason: dep.Explicit,
  453. Version: "91.0.0-1",
  454. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  455. AURBase: ptrString("yay"),
  456. },
  457. },
  458. },
  459. },
  460. {
  461. desc: "one layer -- fail install",
  462. wantErrInstall: true,
  463. wantErrCompile: false,
  464. failBuild: false,
  465. failPkgInstall: true,
  466. targets: []map[string]*dep.InstallInfo{
  467. {
  468. "yay": {
  469. Source: dep.AUR,
  470. Reason: dep.Explicit,
  471. Version: "91.0.0-1",
  472. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  473. AURBase: ptrString("yay"),
  474. },
  475. },
  476. },
  477. },
  478. {
  479. desc: "two layers",
  480. wantErrInstall: false,
  481. wantErrCompile: true,
  482. failBuild: true,
  483. failPkgInstall: false,
  484. targets: []map[string]*dep.InstallInfo{
  485. {"bob": {
  486. AURBase: ptrString("yay"),
  487. }},
  488. {
  489. "yay": {
  490. Source: dep.AUR,
  491. Reason: dep.Explicit,
  492. Version: "91.0.0-1",
  493. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  494. AURBase: ptrString("yay"),
  495. },
  496. },
  497. },
  498. },
  499. }
  500. for _, tc := range testCases {
  501. tc := tc
  502. t.Run(tc.desc, func(td *testing.T) {
  503. pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
  504. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  505. return pkgTar, "", nil
  506. }
  507. showOverride := func(cmd *exec.Cmd) error {
  508. if tc.failBuild && strings.Contains(cmd.String(), "makepkg -f --noconfirm") && cmd.Dir == tmpDir {
  509. return errors.New("makepkg failed")
  510. }
  511. return nil
  512. }
  513. isCorrectInstalledOverride := func(string, string) bool {
  514. return false
  515. }
  516. mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
  517. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  518. cmdBuilder := &exe.CmdBuilder{
  519. MakepkgBin: makepkgBin,
  520. SudoBin: "su",
  521. PacmanBin: pacmanBin,
  522. Runner: mockRunner,
  523. SudoLoopEnabled: false,
  524. }
  525. cmdBuilder.Runner = mockRunner
  526. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  527. parser.RebuildModeNo, false, newTestLogger())
  528. cmdArgs := parser.MakeArguments()
  529. cmdArgs.AddArg("needed")
  530. cmdArgs.AddTarget("yay")
  531. pkgBuildDirs := map[string]string{
  532. "yay": tmpDir,
  533. }
  534. errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
  535. if tc.wantErrInstall {
  536. require.Error(td, errI)
  537. } else {
  538. require.NoError(td, errI)
  539. }
  540. failed, err := installer.CompileFailedAndIgnored()
  541. if tc.wantErrCompile {
  542. require.Error(td, err)
  543. assert.ErrorContains(td, err, "yay")
  544. assert.Len(t, failed, len(tc.targets))
  545. } else {
  546. require.NoError(td, err)
  547. }
  548. })
  549. }
  550. }
  551. func TestInstaller_InstallSplitPackage(t *testing.T) {
  552. t.Parallel()
  553. makepkgBin := t.TempDir() + "/makepkg"
  554. pacmanBin := t.TempDir() + "/pacman"
  555. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  556. require.NoError(t, err)
  557. require.NoError(t, f.Close())
  558. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  559. require.NoError(t, err)
  560. require.NoError(t, f.Close())
  561. type testCase struct {
  562. desc string
  563. wantShow []string
  564. wantCapture []string
  565. targets []map[string]*dep.InstallInfo
  566. }
  567. tmpDir := t.TempDir()
  568. testCases := []testCase{
  569. {
  570. desc: "jellyfin",
  571. targets: []map[string]*dep.InstallInfo{
  572. {"jellyfin": {
  573. Source: dep.AUR,
  574. Reason: dep.Explicit,
  575. Version: "10.8.4-1",
  576. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  577. AURBase: ptrString("jellyfin"),
  578. }},
  579. {
  580. "jellyfin-server": {
  581. Source: dep.AUR,
  582. Reason: dep.Dep,
  583. Version: "10.8.4-1",
  584. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  585. AURBase: ptrString("jellyfin"),
  586. },
  587. "jellyfin-web": {
  588. Source: dep.AUR,
  589. Reason: dep.Dep,
  590. Version: "10.8.4-1",
  591. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  592. AURBase: ptrString("jellyfin"),
  593. },
  594. },
  595. {
  596. "dotnet-runtime-6.0": {
  597. Source: dep.Sync,
  598. Reason: dep.Dep,
  599. Version: "6.0.12.sdk112-1",
  600. SyncDBName: ptrString("community"),
  601. },
  602. "aspnet-runtime": {
  603. Source: dep.Sync,
  604. Reason: dep.Dep,
  605. Version: "6.0.12.sdk112-1",
  606. SyncDBName: ptrString("community"),
  607. },
  608. "dotnet-sdk-6.0": {
  609. Source: dep.Sync,
  610. Reason: dep.MakeDep,
  611. Version: "6.0.12.sdk112-1",
  612. SyncDBName: ptrString("community"),
  613. },
  614. },
  615. },
  616. wantShow: []string{
  617. "pacman -S --config /etc/pacman.conf -- community/dotnet-runtime-6.0 community/aspnet-runtime community/dotnet-sdk-6.0",
  618. "pacman -D -q --asdeps --config /etc/pacman.conf -- dotnet-runtime-6.0 aspnet-runtime dotnet-sdk-6.0",
  619. "makepkg --nobuild -f -C --ignorearch",
  620. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  621. "pacman -U --config /etc/pacman.conf -- /testdir/jellyfin-web-10.8.4-1-x86_64.pkg.tar.zst /testdir/jellyfin-server-10.8.4-1-x86_64.pkg.tar.zst",
  622. "pacman -D -q --asdeps --config /etc/pacman.conf -- jellyfin-server jellyfin-web",
  623. "makepkg --nobuild -f -C --ignorearch",
  624. "makepkg -c --nobuild --noextract --ignorearch",
  625. "pacman -U --config /etc/pacman.conf -- /testdir/jellyfin-10.8.4-1-x86_64.pkg.tar.zst",
  626. "pacman -D -q --asexplicit --config /etc/pacman.conf -- jellyfin",
  627. },
  628. wantCapture: []string{"makepkg --packagelist", "makepkg --packagelist"},
  629. },
  630. }
  631. for _, tc := range testCases {
  632. tc := tc
  633. t.Run(tc.desc, func(td *testing.T) {
  634. pkgTars := []string{
  635. tmpDir + "/jellyfin-10.8.4-1-x86_64.pkg.tar.zst",
  636. tmpDir + "/jellyfin-web-10.8.4-1-x86_64.pkg.tar.zst",
  637. tmpDir + "/jellyfin-server-10.8.4-1-x86_64.pkg.tar.zst",
  638. }
  639. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  640. return strings.Join(pkgTars, "\n"), "", nil
  641. }
  642. i := 0
  643. showOverride := func(cmd *exec.Cmd) error {
  644. i++
  645. if i == 4 {
  646. for _, pkgTar := range pkgTars {
  647. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  648. require.NoError(td, err)
  649. require.NoError(td, f.Close())
  650. }
  651. }
  652. return nil
  653. }
  654. isCorrectInstalledOverride := func(string, string) bool {
  655. return false
  656. }
  657. mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
  658. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  659. cmdBuilder := &exe.CmdBuilder{
  660. MakepkgBin: makepkgBin,
  661. SudoBin: "su",
  662. PacmanBin: pacmanBin,
  663. PacmanConfigPath: "/etc/pacman.conf",
  664. Runner: mockRunner,
  665. SudoLoopEnabled: false,
  666. }
  667. cmdBuilder.Runner = mockRunner
  668. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  669. parser.RebuildModeNo, false, newTestLogger())
  670. cmdArgs := parser.MakeArguments()
  671. cmdArgs.AddTarget("jellyfin")
  672. pkgBuildDirs := map[string]string{
  673. "jellyfin": tmpDir,
  674. }
  675. errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
  676. require.NoError(td, errI)
  677. require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
  678. require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
  679. for i, call := range mockRunner.ShowCalls {
  680. show := call.Args[0].(*exec.Cmd).String()
  681. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  682. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  683. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  684. // options are in a different order on different systems and on CI root user is used
  685. assert.Subset(td, strings.Split(show, " "),
  686. strings.Split(tc.wantShow[i], " "),
  687. fmt.Sprintf("got at %d: %s \n", i, show))
  688. }
  689. for i, call := range mockRunner.CaptureCalls {
  690. capture := call.Args[0].(*exec.Cmd).String()
  691. capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
  692. capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
  693. capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
  694. assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
  695. }
  696. })
  697. }
  698. }
  699. func TestInstaller_InstallDownloadOnly(t *testing.T) {
  700. t.Parallel()
  701. makepkgBin := t.TempDir() + "/makepkg"
  702. pacmanBin := t.TempDir() + "/pacman"
  703. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  704. require.NoError(t, err)
  705. require.NoError(t, f.Close())
  706. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  707. require.NoError(t, err)
  708. require.NoError(t, f.Close())
  709. type testCase struct {
  710. desc string
  711. isInstalled bool
  712. isBuilt bool
  713. wantShow []string
  714. wantCapture []string
  715. }
  716. testCases := []testCase{
  717. {
  718. desc: "not installed and not built",
  719. isInstalled: false,
  720. isBuilt: false,
  721. wantShow: []string{
  722. "makepkg --nobuild -f -C --ignorearch",
  723. "makepkg -c --nobuild --noextract --ignorearch",
  724. },
  725. wantCapture: []string{"makepkg --packagelist"},
  726. },
  727. {
  728. desc: "not installed and built",
  729. isInstalled: false,
  730. isBuilt: true,
  731. wantShow: []string{
  732. "makepkg --nobuild -f -C --ignorearch",
  733. "makepkg -c --nobuild --noextract --ignorearch",
  734. },
  735. wantCapture: []string{"makepkg --packagelist"},
  736. },
  737. {
  738. desc: "installed",
  739. isInstalled: true,
  740. isBuilt: false,
  741. wantShow: []string{
  742. "makepkg --nobuild -f -C --ignorearch",
  743. "makepkg -c --nobuild --noextract --ignorearch",
  744. },
  745. wantCapture: []string{"makepkg --packagelist"},
  746. },
  747. }
  748. for _, tc := range testCases {
  749. tc := tc
  750. t.Run(tc.desc, func(td *testing.T) {
  751. tmpDir := td.TempDir()
  752. pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
  753. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  754. return pkgTar, "", nil
  755. }
  756. i := 0
  757. showOverride := func(cmd *exec.Cmd) error {
  758. i++
  759. if i == 2 {
  760. if !tc.isBuilt {
  761. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  762. require.NoError(td, err)
  763. require.NoError(td, f.Close())
  764. }
  765. }
  766. return nil
  767. }
  768. // create a mock file
  769. if tc.isBuilt {
  770. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  771. require.NoError(td, err)
  772. require.NoError(td, f.Close())
  773. }
  774. isCorrectInstalledOverride := func(string, string) bool {
  775. return tc.isInstalled
  776. }
  777. mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
  778. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  779. cmdBuilder := &exe.CmdBuilder{
  780. MakepkgBin: makepkgBin,
  781. SudoBin: "su",
  782. PacmanBin: pacmanBin,
  783. Runner: mockRunner,
  784. SudoLoopEnabled: false,
  785. }
  786. cmdBuilder.Runner = mockRunner
  787. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  788. parser.RebuildModeNo, true, newTestLogger())
  789. cmdArgs := parser.MakeArguments()
  790. cmdArgs.AddTarget("yay")
  791. pkgBuildDirs := map[string]string{
  792. "yay": tmpDir,
  793. }
  794. targets := []map[string]*dep.InstallInfo{
  795. {
  796. "yay": {
  797. Source: dep.AUR,
  798. Reason: dep.Explicit,
  799. Version: "91.0.0-1",
  800. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  801. AURBase: ptrString("yay"),
  802. },
  803. },
  804. }
  805. errI := installer.Install(context.Background(), cmdArgs, targets, pkgBuildDirs, []string{}, false)
  806. require.NoError(td, errI)
  807. require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
  808. require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
  809. require.Empty(td, installer.failedAndIgnored)
  810. for i, call := range mockRunner.ShowCalls {
  811. show := call.Args[0].(*exec.Cmd).String()
  812. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  813. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  814. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  815. // options are in a different order on different systems and on CI root user is used
  816. assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
  817. }
  818. for i, call := range mockRunner.CaptureCalls {
  819. capture := call.Args[0].(*exec.Cmd).String()
  820. capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
  821. capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
  822. capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
  823. assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
  824. }
  825. })
  826. }
  827. }
  828. func TestInstaller_InstallGroup(t *testing.T) {
  829. t.Parallel()
  830. makepkgBin := t.TempDir() + "/makepkg"
  831. pacmanBin := t.TempDir() + "/pacman"
  832. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  833. require.NoError(t, err)
  834. require.NoError(t, f.Close())
  835. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  836. require.NoError(t, err)
  837. require.NoError(t, f.Close())
  838. type testCase struct {
  839. desc string
  840. wantShow []string
  841. wantCapture []string
  842. }
  843. testCases := []testCase{
  844. {
  845. desc: "group",
  846. wantShow: []string{
  847. "pacman -S --noconfirm --config -- community/kubernetes-tools",
  848. },
  849. wantCapture: []string{},
  850. },
  851. }
  852. for _, tc := range testCases {
  853. tc := tc
  854. t.Run(tc.desc, func(td *testing.T) {
  855. tmpDir := td.TempDir()
  856. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  857. return "", "", nil
  858. }
  859. showOverride := func(cmd *exec.Cmd) error {
  860. return nil
  861. }
  862. mockDB := &mock.DBExecutor{}
  863. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  864. cmdBuilder := &exe.CmdBuilder{
  865. MakepkgBin: makepkgBin,
  866. SudoBin: "su",
  867. PacmanBin: pacmanBin,
  868. Runner: mockRunner,
  869. SudoLoopEnabled: false,
  870. }
  871. cmdBuilder.Runner = mockRunner
  872. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  873. parser.RebuildModeNo, true, newTestLogger())
  874. cmdArgs := parser.MakeArguments()
  875. cmdArgs.AddTarget("kubernetes-tools")
  876. pkgBuildDirs := map[string]string{}
  877. targets := []map[string]*dep.InstallInfo{
  878. {
  879. "kubernetes-tools": {
  880. Source: dep.Sync,
  881. Reason: dep.Explicit,
  882. Version: "",
  883. IsGroup: true,
  884. SyncDBName: ptrString("community"),
  885. },
  886. },
  887. }
  888. errI := installer.Install(context.Background(), cmdArgs, targets, pkgBuildDirs, []string{}, false)
  889. require.NoError(td, errI)
  890. require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
  891. require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
  892. require.Empty(td, installer.failedAndIgnored)
  893. for i, call := range mockRunner.ShowCalls {
  894. show := call.Args[0].(*exec.Cmd).String()
  895. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  896. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  897. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  898. // options are in a different order on different systems and on CI root user is used
  899. assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
  900. }
  901. for i, call := range mockRunner.CaptureCalls {
  902. capture := call.Args[0].(*exec.Cmd).String()
  903. capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
  904. capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
  905. capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
  906. assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
  907. }
  908. })
  909. }
  910. }
  911. func TestInstaller_InstallRebuild(t *testing.T) {
  912. t.Parallel()
  913. makepkgBin := t.TempDir() + "/makepkg"
  914. pacmanBin := t.TempDir() + "/pacman"
  915. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  916. require.NoError(t, err)
  917. require.NoError(t, f.Close())
  918. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  919. require.NoError(t, err)
  920. require.NoError(t, f.Close())
  921. type testCase struct {
  922. desc string
  923. rebuildOption parser.RebuildMode
  924. isInstalled bool
  925. isBuilt bool
  926. wantShow []string
  927. wantCapture []string
  928. targets []map[string]*dep.InstallInfo
  929. }
  930. tmpDir := t.TempDir()
  931. testCases := []testCase{
  932. {
  933. desc: "--norebuild(default) when built and not installed",
  934. rebuildOption: parser.RebuildModeNo,
  935. isBuilt: true,
  936. isInstalled: false,
  937. wantShow: []string{
  938. "makepkg --nobuild -f -C --ignorearch",
  939. "makepkg -c --nobuild --noextract --ignorearch",
  940. "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  941. "pacman -D -q --asexplicit --config -- yay",
  942. },
  943. wantCapture: []string{"makepkg --packagelist"},
  944. targets: []map[string]*dep.InstallInfo{
  945. {
  946. "yay": {
  947. Source: dep.AUR,
  948. Reason: dep.Explicit,
  949. Version: "91.0.0-1",
  950. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  951. AURBase: ptrString("yay"),
  952. },
  953. },
  954. },
  955. },
  956. {
  957. desc: "--rebuild when built and not installed",
  958. rebuildOption: parser.RebuildModeYes,
  959. isBuilt: true,
  960. isInstalled: false,
  961. wantShow: []string{
  962. "makepkg --nobuild -f -C --ignorearch",
  963. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  964. "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  965. "pacman -D -q --asexplicit --config -- yay",
  966. },
  967. wantCapture: []string{"makepkg --packagelist"},
  968. targets: []map[string]*dep.InstallInfo{
  969. {
  970. "yay": {
  971. Source: dep.AUR,
  972. Reason: dep.Explicit,
  973. Version: "91.0.0-1",
  974. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  975. AURBase: ptrString("yay"),
  976. },
  977. },
  978. },
  979. },
  980. {
  981. desc: "--rebuild when built and installed",
  982. rebuildOption: parser.RebuildModeYes,
  983. isInstalled: true,
  984. isBuilt: true,
  985. wantShow: []string{
  986. "makepkg --nobuild -f -C --ignorearch",
  987. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  988. "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  989. "pacman -D -q --asexplicit --config -- yay",
  990. },
  991. wantCapture: []string{"makepkg --packagelist"},
  992. targets: []map[string]*dep.InstallInfo{
  993. {
  994. "yay": {
  995. Source: dep.AUR,
  996. Reason: dep.Explicit,
  997. Version: "91.0.0-1",
  998. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  999. AURBase: ptrString("yay"),
  1000. },
  1001. },
  1002. },
  1003. },
  1004. {
  1005. desc: "--rebuild when built and installed previously as dep",
  1006. rebuildOption: parser.RebuildModeYes,
  1007. isInstalled: true,
  1008. isBuilt: true,
  1009. wantShow: []string{
  1010. "makepkg --nobuild -f -C --ignorearch",
  1011. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  1012. "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  1013. "pacman -D -q --asdeps --config -- yay",
  1014. },
  1015. wantCapture: []string{"makepkg --packagelist"},
  1016. targets: []map[string]*dep.InstallInfo{
  1017. {
  1018. "yay": {
  1019. Source: dep.AUR,
  1020. Reason: dep.Dep,
  1021. Version: "91.0.0-1",
  1022. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  1023. AURBase: ptrString("yay"),
  1024. },
  1025. },
  1026. },
  1027. },
  1028. }
  1029. for _, tc := range testCases {
  1030. tc := tc
  1031. t.Run(tc.desc, func(td *testing.T) {
  1032. tmpDir := td.TempDir()
  1033. pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
  1034. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  1035. return pkgTar, "", nil
  1036. }
  1037. i := 0
  1038. showOverride := func(cmd *exec.Cmd) error {
  1039. i++
  1040. if i == 2 {
  1041. if !tc.isBuilt {
  1042. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  1043. require.NoError(td, err)
  1044. require.NoError(td, f.Close())
  1045. }
  1046. }
  1047. return nil
  1048. }
  1049. // create a mock file
  1050. if tc.isBuilt {
  1051. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  1052. require.NoError(td, err)
  1053. require.NoError(td, f.Close())
  1054. }
  1055. isCorrectInstalledOverride := func(string, string) bool {
  1056. return tc.isInstalled
  1057. }
  1058. mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
  1059. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  1060. cmdBuilder := &exe.CmdBuilder{
  1061. MakepkgBin: makepkgBin,
  1062. SudoBin: "su",
  1063. PacmanBin: pacmanBin,
  1064. Runner: mockRunner,
  1065. SudoLoopEnabled: false,
  1066. }
  1067. cmdBuilder.Runner = mockRunner
  1068. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  1069. tc.rebuildOption, false, newTestLogger())
  1070. cmdArgs := parser.MakeArguments()
  1071. cmdArgs.AddTarget("yay")
  1072. pkgBuildDirs := map[string]string{
  1073. "yay": tmpDir,
  1074. }
  1075. errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
  1076. require.NoError(td, errI)
  1077. require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
  1078. require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
  1079. for i, call := range mockRunner.ShowCalls {
  1080. show := call.Args[0].(*exec.Cmd).String()
  1081. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  1082. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  1083. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  1084. // options are in a different order on different systems and on CI root user is used
  1085. assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
  1086. }
  1087. for i, call := range mockRunner.CaptureCalls {
  1088. capture := call.Args[0].(*exec.Cmd).String()
  1089. capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
  1090. capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
  1091. capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
  1092. assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
  1093. }
  1094. })
  1095. }
  1096. }
  1097. func TestInstaller_InstallUpgrade(t *testing.T) {
  1098. t.Parallel()
  1099. makepkgBin := t.TempDir() + "/makepkg"
  1100. pacmanBin := t.TempDir() + "/pacman"
  1101. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  1102. require.NoError(t, err)
  1103. require.NoError(t, f.Close())
  1104. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  1105. require.NoError(t, err)
  1106. require.NoError(t, f.Close())
  1107. type testCase struct {
  1108. desc string
  1109. targetMode parser.TargetMode
  1110. }
  1111. tmpDir := t.TempDir()
  1112. testCases := []testCase{
  1113. {
  1114. desc: "target any",
  1115. targetMode: parser.ModeAny,
  1116. },
  1117. {
  1118. desc: "target repo",
  1119. targetMode: parser.ModeRepo,
  1120. },
  1121. {
  1122. desc: "target aur",
  1123. targetMode: parser.ModeAUR,
  1124. },
  1125. }
  1126. for _, tc := range testCases {
  1127. tc := tc
  1128. t.Run(tc.desc, func(td *testing.T) {
  1129. mockDB := &mock.DBExecutor{}
  1130. mockRunner := &exe.MockRunner{}
  1131. cmdBuilder := &exe.CmdBuilder{
  1132. MakepkgBin: makepkgBin,
  1133. SudoBin: "su",
  1134. PacmanBin: pacmanBin,
  1135. Runner: mockRunner,
  1136. SudoLoopEnabled: false,
  1137. }
  1138. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, tc.targetMode,
  1139. parser.RebuildModeNo, false, newTestLogger())
  1140. cmdArgs := parser.MakeArguments()
  1141. cmdArgs.AddArg("u", "upgrades") // Make sure both args are removed
  1142. targets := []map[string]*dep.InstallInfo{
  1143. {
  1144. "linux": {
  1145. Source: dep.Sync,
  1146. Reason: dep.Dep,
  1147. Version: "17.0.0-1",
  1148. SyncDBName: ptrString("core"),
  1149. },
  1150. },
  1151. }
  1152. errI := installer.Install(context.Background(), cmdArgs, targets, map[string]string{}, []string{}, false)
  1153. require.NoError(td, errI)
  1154. require.NotEmpty(td, mockRunner.ShowCalls)
  1155. // The first call is the only call being test
  1156. call := mockRunner.ShowCalls[0]
  1157. show := call.Args[0].(*exec.Cmd).String()
  1158. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  1159. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  1160. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  1161. if tc.targetMode == parser.ModeAUR {
  1162. assert.NotContains(td, show, "--upgrades")
  1163. assert.NotContains(td, show, "-u")
  1164. } else {
  1165. assert.Contains(td, show, "--upgrades")
  1166. assert.Contains(td, show, "-u")
  1167. }
  1168. })
  1169. }
  1170. }
  1171. func TestInstaller_KeepSrc(t *testing.T) {
  1172. t.Parallel()
  1173. makepkgBin := t.TempDir() + "/makepkg"
  1174. pacmanBin := t.TempDir() + "/pacman"
  1175. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  1176. require.NoError(t, err)
  1177. require.NoError(t, f.Close())
  1178. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  1179. require.NoError(t, err)
  1180. require.NoError(t, f.Close())
  1181. type testCase struct {
  1182. desc string
  1183. wantShow []string
  1184. targets []map[string]*dep.InstallInfo
  1185. }
  1186. tmpDir := t.TempDir()
  1187. testCases := []testCase{
  1188. {
  1189. desc: "--keepsrc",
  1190. wantShow: []string{
  1191. "makepkg --nobuild -f --ignorearch",
  1192. "makepkg --nobuild --noextract --ignorearch",
  1193. "pacman -U --config -- /testdir/yay-92.0.0-1-x86_64.pkg.tar.zst",
  1194. "pacman -D -q --asexplicit --config -- yay",
  1195. },
  1196. targets: []map[string]*dep.InstallInfo{
  1197. {
  1198. "yay": {
  1199. Source: dep.AUR,
  1200. Reason: dep.Explicit,
  1201. Version: "92.0.0-1",
  1202. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  1203. AURBase: ptrString("yay"),
  1204. },
  1205. },
  1206. },
  1207. },
  1208. }
  1209. for _, tc := range testCases {
  1210. tc := tc
  1211. t.Run(tc.desc, func(td *testing.T) {
  1212. tmpDir := td.TempDir()
  1213. pkgTar := tmpDir + "/yay-92.0.0-1-x86_64.pkg.tar.zst"
  1214. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  1215. return pkgTar, "", nil
  1216. }
  1217. // create a mock file
  1218. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  1219. require.NoError(td, err)
  1220. require.NoError(td, f.Close())
  1221. mockDB := &mock.DBExecutor{}
  1222. mockRunner := &exe.MockRunner{CaptureFn: captureOverride}
  1223. cmdBuilder := &exe.CmdBuilder{
  1224. MakepkgBin: makepkgBin,
  1225. SudoBin: "su",
  1226. PacmanBin: pacmanBin,
  1227. KeepSrc: true,
  1228. Runner: mockRunner,
  1229. SudoLoopEnabled: false,
  1230. }
  1231. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  1232. parser.RebuildModeNo, false, newTestLogger())
  1233. cmdArgs := parser.MakeArguments()
  1234. cmdArgs.AddTarget("yay")
  1235. pkgBuildDirs := map[string]string{
  1236. "yay": tmpDir,
  1237. }
  1238. errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
  1239. require.NoError(td, errI)
  1240. require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
  1241. for i, call := range mockRunner.ShowCalls {
  1242. show := call.Args[0].(*exec.Cmd).String()
  1243. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  1244. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  1245. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  1246. // options are in a different order on different systems and on CI root user is used
  1247. assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
  1248. // Only assert makepkg commands don't have clean arguments
  1249. if strings.HasPrefix(show, "makepkg") {
  1250. assert.NotContains(td, show, "-c")
  1251. assert.NotContains(td, show, "-C")
  1252. }
  1253. }
  1254. })
  1255. }
  1256. }