1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441 |
- package build
- import (
- "context"
- "errors"
- "fmt"
- "io"
- "os"
- "os/exec"
- "strings"
- "testing"
- "github.com/stretchr/testify/assert"
- "github.com/stretchr/testify/require"
- "github.com/Jguer/yay/v12/pkg/db/mock"
- "github.com/Jguer/yay/v12/pkg/dep"
- "github.com/Jguer/yay/v12/pkg/settings/exe"
- "github.com/Jguer/yay/v12/pkg/settings/parser"
- "github.com/Jguer/yay/v12/pkg/text"
- "github.com/Jguer/yay/v12/pkg/vcs"
- )
- func newTestLogger() *text.Logger {
- return text.NewLogger(io.Discard, io.Discard, strings.NewReader(""), true, "test")
- }
- func ptrString(s string) *string {
- return &s
- }
- func TestInstaller_InstallNeeded(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- isInstalled bool
- isBuilt bool
- wantShow []string
- wantCapture []string
- }
- testCases := []testCase{
- {
- desc: "not installed and not built",
- isInstalled: false,
- isBuilt: false,
- wantShow: []string{
- "makepkg --nobuild -f -C --ignorearch",
- "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --needed --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- },
- {
- desc: "not installed and built",
- isInstalled: false,
- isBuilt: true,
- wantShow: []string{
- "makepkg --nobuild -f -C --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- "pacman -U --needed --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- },
- {
- desc: "installed",
- isInstalled: true,
- isBuilt: false,
- wantShow: []string{
- "makepkg --nobuild -f -C --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- },
- wantCapture: []string{"makepkg --packagelist"},
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- tmpDir := td.TempDir()
- pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- return pkgTar, "", nil
- }
- i := 0
- showOverride := func(cmd *exec.Cmd) error {
- i++
- if i == 2 {
- if !tc.isBuilt {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- }
- return nil
- }
- // create a mock file
- if tc.isBuilt {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- isCorrectInstalledOverride := func(string, string) bool {
- return tc.isInstalled
- }
- mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- parser.RebuildModeNo, false, newTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddArg("needed")
- cmdArgs.AddTarget("yay")
- pkgBuildDirs := map[string]string{
- "yay": tmpDir,
- }
- targets := []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- }
- errI := installer.Install(context.Background(), cmdArgs, targets, pkgBuildDirs, []string{}, false)
- require.NoError(td, errI)
- require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
- require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
- for i, call := range mockRunner.ShowCalls {
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- // options are in a different order on different systems and on CI root user is used
- assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
- }
- for i, call := range mockRunner.CaptureCalls {
- capture := call.Args[0].(*exec.Cmd).String()
- capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
- capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
- capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
- assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
- }
- })
- }
- }
- func TestInstaller_InstallMixedSourcesAndLayers(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- targets []map[string]*dep.InstallInfo
- wantShow []string
- wantCapture []string
- }
- tmpDir := t.TempDir()
- tmpDirJfin := t.TempDir()
- testCases := []testCase{
- {
- desc: "same layer -- different sources",
- wantShow: []string{
- "pacman -S --config /etc/pacman.conf -- core/linux",
- "pacman -D -q --asdeps --config /etc/pacman.conf -- linux",
- "makepkg --nobuild -f -C --ignorearch",
- "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- "linux": {
- Source: dep.Sync,
- Reason: dep.Dep,
- Version: "17.0.0-1",
- SyncDBName: ptrString("core"),
- },
- },
- },
- },
- {
- desc: "different layer -- different sources",
- wantShow: []string{
- "pacman -S --config /etc/pacman.conf -- core/linux",
- "pacman -D -q --asdeps --config /etc/pacman.conf -- linux",
- "makepkg --nobuild -f -C --ignorearch",
- "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- }, {
- "linux": {
- Source: dep.Sync,
- Reason: dep.Dep,
- Version: "17.0.0-1",
- SyncDBName: ptrString("core"),
- },
- },
- },
- },
- {
- desc: "same layer -- sync",
- wantShow: []string{
- "pacman -S --config /etc/pacman.conf -- extra/linux-zen core/linux",
- "pacman -D -q --asexplicit --config /etc/pacman.conf -- linux-zen linux",
- },
- wantCapture: []string{},
- targets: []map[string]*dep.InstallInfo{
- {
- "linux-zen": {
- Source: dep.Sync,
- Reason: dep.Explicit,
- Version: "18.0.0-1",
- SyncDBName: ptrString("extra"),
- },
- "linux": {
- Source: dep.Sync,
- Reason: dep.Explicit,
- Version: "17.0.0-1",
- SyncDBName: ptrString("core"),
- },
- },
- },
- },
- {
- desc: "same layer -- aur",
- wantShow: []string{
- "makepkg --nobuild -f -C --ignorearch",
- "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
- "makepkg --nobuild -f -C --ignorearch",
- "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config /etc/pacman.conf -- pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
- },
- wantCapture: []string{"makepkg --packagelist", "makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- "jellyfin-server": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "10.8.8-1",
- SrcinfoPath: ptrString(tmpDirJfin + "/.SRCINFO"),
- AURBase: ptrString("jellyfin"),
- },
- },
- },
- },
- {
- desc: "different layer -- aur",
- wantShow: []string{
- "makepkg --nobuild -f -C --ignorearch",
- "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config /etc/pacman.conf -- pacman -U --config /etc/pacman.conf -- /testdir/jellyfin-server-10.8.8-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asdeps --config /etc/pacman.conf -- jellyfin-server",
- "makepkg --nobuild -f -C --ignorearch",
- "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config /etc/pacman.conf -- pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
- },
- wantCapture: []string{"makepkg --packagelist", "makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- }, {
- "jellyfin-server": {
- Source: dep.AUR,
- Reason: dep.MakeDep,
- Version: "10.8.8-1",
- SrcinfoPath: ptrString(tmpDirJfin + "/.SRCINFO"),
- AURBase: ptrString("jellyfin"),
- },
- },
- },
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
- jfinPkgTar := tmpDirJfin + "/jellyfin-server-10.8.8-1-x86_64.pkg.tar.zst"
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- if cmd.Dir == tmpDirJfin {
- return jfinPkgTar, "", nil
- }
- if cmd.Dir == tmpDir {
- return pkgTar, "", nil
- }
- return "", "", fmt.Errorf("unexpected command: %s - %s", cmd.String(), cmd.Dir)
- }
- showOverride := func(cmd *exec.Cmd) error {
- if strings.Contains(cmd.String(), "makepkg -f --noconfirm") && cmd.Dir == tmpDir {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- if strings.Contains(cmd.String(), "makepkg -f --noconfirm") && cmd.Dir == tmpDirJfin {
- f, err := os.OpenFile(jfinPkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- return nil
- }
- defer os.Remove(pkgTar)
- defer os.Remove(jfinPkgTar)
- isCorrectInstalledOverride := func(string, string) bool {
- return false
- }
- mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- PacmanConfigPath: "/etc/pacman.conf",
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny, parser.RebuildModeNo, false, newTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddTarget("yay")
- pkgBuildDirs := map[string]string{
- "yay": tmpDir,
- "jellyfin": tmpDirJfin,
- }
- errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
- require.NoError(td, errI)
- require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
- require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
- for i, call := range mockRunner.ShowCalls {
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, tmpDirJfin, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- // options are in a different order on different systems and on CI root user is used
- assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
- }
- for i, call := range mockRunner.CaptureCalls {
- capture := call.Args[0].(*exec.Cmd).String()
- capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
- capture = strings.ReplaceAll(capture, tmpDirJfin, "/testdir")
- capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
- capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
- assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
- }
- })
- }
- }
- func TestInstaller_RunPostHooks(t *testing.T) {
- mockDB := &mock.DBExecutor{}
- mockRunner := &exe.MockRunner{}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: "makepkg",
- SudoBin: "su",
- PacmanBin: "pacman",
- PacmanConfigPath: "/etc/pacman.conf",
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- parser.RebuildModeNo, false, newTestLogger())
- called := false
- hook := func(ctx context.Context) error {
- called = true
- return nil
- }
- installer.AddPostInstallHook(hook)
- installer.RunPostInstallHooks(context.Background())
- assert.True(t, called)
- }
- func TestInstaller_CompileFailed(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- targets []map[string]*dep.InstallInfo
- wantErrInstall bool
- wantErrCompile bool
- failBuild bool
- failPkgInstall bool
- }
- tmpDir := t.TempDir()
- testCases := []testCase{
- {
- desc: "one layer",
- wantErrInstall: false,
- wantErrCompile: true,
- failBuild: true,
- failPkgInstall: false,
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- {
- desc: "one layer -- fail install",
- wantErrInstall: true,
- wantErrCompile: false,
- failBuild: false,
- failPkgInstall: true,
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- {
- desc: "two layers",
- wantErrInstall: false,
- wantErrCompile: true,
- failBuild: true,
- failPkgInstall: false,
- targets: []map[string]*dep.InstallInfo{
- {"bob": {
- AURBase: ptrString("yay"),
- }},
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- return pkgTar, "", nil
- }
- showOverride := func(cmd *exec.Cmd) error {
- if tc.failBuild && strings.Contains(cmd.String(), "makepkg -f --noconfirm") && cmd.Dir == tmpDir {
- return errors.New("makepkg failed")
- }
- return nil
- }
- isCorrectInstalledOverride := func(string, string) bool {
- return false
- }
- mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- parser.RebuildModeNo, false, newTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddArg("needed")
- cmdArgs.AddTarget("yay")
- pkgBuildDirs := map[string]string{
- "yay": tmpDir,
- }
- errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
- if tc.wantErrInstall {
- require.Error(td, errI)
- } else {
- require.NoError(td, errI)
- }
- failed, err := installer.CompileFailedAndIgnored()
- if tc.wantErrCompile {
- require.Error(td, err)
- assert.ErrorContains(td, err, "yay")
- assert.Len(t, failed, len(tc.targets))
- } else {
- require.NoError(td, err)
- }
- })
- }
- }
- func TestInstaller_InstallSplitPackage(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- wantShow []string
- wantCapture []string
- targets []map[string]*dep.InstallInfo
- }
- tmpDir := t.TempDir()
- testCases := []testCase{
- {
- desc: "jellyfin",
- targets: []map[string]*dep.InstallInfo{
- {"jellyfin": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "10.8.4-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("jellyfin"),
- }},
- {
- "jellyfin-server": {
- Source: dep.AUR,
- Reason: dep.Dep,
- Version: "10.8.4-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("jellyfin"),
- },
- "jellyfin-web": {
- Source: dep.AUR,
- Reason: dep.Dep,
- Version: "10.8.4-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("jellyfin"),
- },
- },
- {
- "dotnet-runtime-6.0": {
- Source: dep.Sync,
- Reason: dep.Dep,
- Version: "6.0.12.sdk112-1",
- SyncDBName: ptrString("community"),
- },
- "aspnet-runtime": {
- Source: dep.Sync,
- Reason: dep.Dep,
- Version: "6.0.12.sdk112-1",
- SyncDBName: ptrString("community"),
- },
- "dotnet-sdk-6.0": {
- Source: dep.Sync,
- Reason: dep.MakeDep,
- Version: "6.0.12.sdk112-1",
- SyncDBName: ptrString("community"),
- },
- },
- },
- wantShow: []string{
- "pacman -S --config /etc/pacman.conf -- community/dotnet-runtime-6.0 community/aspnet-runtime community/dotnet-sdk-6.0",
- "pacman -D -q --asdeps --config /etc/pacman.conf -- dotnet-runtime-6.0 aspnet-runtime dotnet-sdk-6.0",
- "makepkg --nobuild -f -C --ignorearch",
- "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config /etc/pacman.conf -- /testdir/jellyfin-web-10.8.4-1-x86_64.pkg.tar.zst /testdir/jellyfin-server-10.8.4-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asdeps --config /etc/pacman.conf -- jellyfin-server jellyfin-web",
- "makepkg --nobuild -f -C --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- "pacman -U --config /etc/pacman.conf -- /testdir/jellyfin-10.8.4-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config /etc/pacman.conf -- jellyfin",
- },
- wantCapture: []string{"makepkg --packagelist", "makepkg --packagelist"},
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- pkgTars := []string{
- tmpDir + "/jellyfin-10.8.4-1-x86_64.pkg.tar.zst",
- tmpDir + "/jellyfin-web-10.8.4-1-x86_64.pkg.tar.zst",
- tmpDir + "/jellyfin-server-10.8.4-1-x86_64.pkg.tar.zst",
- }
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- return strings.Join(pkgTars, "\n"), "", nil
- }
- i := 0
- showOverride := func(cmd *exec.Cmd) error {
- i++
- if i == 4 {
- for _, pkgTar := range pkgTars {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- }
- return nil
- }
- isCorrectInstalledOverride := func(string, string) bool {
- return false
- }
- mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- PacmanConfigPath: "/etc/pacman.conf",
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- parser.RebuildModeNo, false, newTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddTarget("jellyfin")
- pkgBuildDirs := map[string]string{
- "jellyfin": tmpDir,
- }
- errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
- require.NoError(td, errI)
- require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
- require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
- for i, call := range mockRunner.ShowCalls {
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- // options are in a different order on different systems and on CI root user is used
- assert.Subset(td, strings.Split(show, " "),
- strings.Split(tc.wantShow[i], " "),
- fmt.Sprintf("got at %d: %s \n", i, show))
- }
- for i, call := range mockRunner.CaptureCalls {
- capture := call.Args[0].(*exec.Cmd).String()
- capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
- capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
- capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
- assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
- }
- })
- }
- }
- func TestInstaller_InstallDownloadOnly(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- isInstalled bool
- isBuilt bool
- wantShow []string
- wantCapture []string
- }
- testCases := []testCase{
- {
- desc: "not installed and not built",
- isInstalled: false,
- isBuilt: false,
- wantShow: []string{
- "makepkg --nobuild -f -C --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- },
- wantCapture: []string{"makepkg --packagelist"},
- },
- {
- desc: "not installed and built",
- isInstalled: false,
- isBuilt: true,
- wantShow: []string{
- "makepkg --nobuild -f -C --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- },
- wantCapture: []string{"makepkg --packagelist"},
- },
- {
- desc: "installed",
- isInstalled: true,
- isBuilt: false,
- wantShow: []string{
- "makepkg --nobuild -f -C --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- },
- wantCapture: []string{"makepkg --packagelist"},
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- tmpDir := td.TempDir()
- pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- return pkgTar, "", nil
- }
- i := 0
- showOverride := func(cmd *exec.Cmd) error {
- i++
- if i == 2 {
- if !tc.isBuilt {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- }
- return nil
- }
- // create a mock file
- if tc.isBuilt {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- isCorrectInstalledOverride := func(string, string) bool {
- return tc.isInstalled
- }
- mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- parser.RebuildModeNo, true, newTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddTarget("yay")
- pkgBuildDirs := map[string]string{
- "yay": tmpDir,
- }
- targets := []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- }
- errI := installer.Install(context.Background(), cmdArgs, targets, pkgBuildDirs, []string{}, false)
- require.NoError(td, errI)
- require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
- require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
- require.Empty(td, installer.failedAndIgnored)
- for i, call := range mockRunner.ShowCalls {
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- // options are in a different order on different systems and on CI root user is used
- assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
- }
- for i, call := range mockRunner.CaptureCalls {
- capture := call.Args[0].(*exec.Cmd).String()
- capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
- capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
- capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
- assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
- }
- })
- }
- }
- func TestInstaller_InstallGroup(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- wantShow []string
- wantCapture []string
- }
- testCases := []testCase{
- {
- desc: "group",
- wantShow: []string{
- "pacman -S --noconfirm --config -- community/kubernetes-tools",
- },
- wantCapture: []string{},
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- tmpDir := td.TempDir()
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- return "", "", nil
- }
- showOverride := func(cmd *exec.Cmd) error {
- return nil
- }
- mockDB := &mock.DBExecutor{}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- parser.RebuildModeNo, true, newTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddTarget("kubernetes-tools")
- pkgBuildDirs := map[string]string{}
- targets := []map[string]*dep.InstallInfo{
- {
- "kubernetes-tools": {
- Source: dep.Sync,
- Reason: dep.Explicit,
- Version: "",
- IsGroup: true,
- SyncDBName: ptrString("community"),
- },
- },
- }
- errI := installer.Install(context.Background(), cmdArgs, targets, pkgBuildDirs, []string{}, false)
- require.NoError(td, errI)
- require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
- require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
- require.Empty(td, installer.failedAndIgnored)
- for i, call := range mockRunner.ShowCalls {
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- // options are in a different order on different systems and on CI root user is used
- assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
- }
- for i, call := range mockRunner.CaptureCalls {
- capture := call.Args[0].(*exec.Cmd).String()
- capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
- capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
- capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
- assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
- }
- })
- }
- }
- func TestInstaller_InstallRebuild(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- rebuildOption parser.RebuildMode
- isInstalled bool
- isBuilt bool
- wantShow []string
- wantCapture []string
- targets []map[string]*dep.InstallInfo
- }
- tmpDir := t.TempDir()
- testCases := []testCase{
- {
- desc: "--norebuild(default) when built and not installed",
- rebuildOption: parser.RebuildModeNo,
- isBuilt: true,
- isInstalled: false,
- wantShow: []string{
- "makepkg --nobuild -f -C --ignorearch",
- "makepkg -c --nobuild --noextract --ignorearch",
- "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- {
- desc: "--rebuild when built and not installed",
- rebuildOption: parser.RebuildModeYes,
- isBuilt: true,
- isInstalled: false,
- wantShow: []string{
- "makepkg --nobuild -f -C --ignorearch",
- "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- {
- desc: "--rebuild when built and installed",
- rebuildOption: parser.RebuildModeYes,
- isInstalled: true,
- isBuilt: true,
- wantShow: []string{
- "makepkg --nobuild -f -C --ignorearch",
- "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- {
- desc: "--rebuild when built and installed previously as dep",
- rebuildOption: parser.RebuildModeYes,
- isInstalled: true,
- isBuilt: true,
- wantShow: []string{
- "makepkg --nobuild -f -C --ignorearch",
- "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
- "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asdeps --config -- yay",
- },
- wantCapture: []string{"makepkg --packagelist"},
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Dep,
- Version: "91.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- tmpDir := td.TempDir()
- pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- return pkgTar, "", nil
- }
- i := 0
- showOverride := func(cmd *exec.Cmd) error {
- i++
- if i == 2 {
- if !tc.isBuilt {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- }
- return nil
- }
- // create a mock file
- if tc.isBuilt {
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- }
- isCorrectInstalledOverride := func(string, string) bool {
- return tc.isInstalled
- }
- mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- cmdBuilder.Runner = mockRunner
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- tc.rebuildOption, false, newTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddTarget("yay")
- pkgBuildDirs := map[string]string{
- "yay": tmpDir,
- }
- errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
- require.NoError(td, errI)
- require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
- require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
- for i, call := range mockRunner.ShowCalls {
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- // options are in a different order on different systems and on CI root user is used
- assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
- }
- for i, call := range mockRunner.CaptureCalls {
- capture := call.Args[0].(*exec.Cmd).String()
- capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
- capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
- capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
- assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
- }
- })
- }
- }
- func TestInstaller_InstallUpgrade(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- targetMode parser.TargetMode
- }
- tmpDir := t.TempDir()
- testCases := []testCase{
- {
- desc: "target any",
- targetMode: parser.ModeAny,
- },
- {
- desc: "target repo",
- targetMode: parser.ModeRepo,
- },
- {
- desc: "target aur",
- targetMode: parser.ModeAUR,
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- mockDB := &mock.DBExecutor{}
- mockRunner := &exe.MockRunner{}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, tc.targetMode,
- parser.RebuildModeNo, false, newTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddArg("u", "upgrades") // Make sure both args are removed
- targets := []map[string]*dep.InstallInfo{
- {
- "linux": {
- Source: dep.Sync,
- Reason: dep.Dep,
- Version: "17.0.0-1",
- SyncDBName: ptrString("core"),
- },
- },
- }
- errI := installer.Install(context.Background(), cmdArgs, targets, map[string]string{}, []string{}, false)
- require.NoError(td, errI)
- require.NotEmpty(td, mockRunner.ShowCalls)
- // The first call is the only call being test
- call := mockRunner.ShowCalls[0]
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- if tc.targetMode == parser.ModeAUR {
- assert.NotContains(td, show, "--upgrades")
- assert.NotContains(td, show, "-u")
- } else {
- assert.Contains(td, show, "--upgrades")
- assert.Contains(td, show, "-u")
- }
- })
- }
- }
- func TestInstaller_KeepSrc(t *testing.T) {
- t.Parallel()
- makepkgBin := t.TempDir() + "/makepkg"
- pacmanBin := t.TempDir() + "/pacman"
- f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
- require.NoError(t, err)
- require.NoError(t, f.Close())
- type testCase struct {
- desc string
- wantShow []string
- targets []map[string]*dep.InstallInfo
- }
- tmpDir := t.TempDir()
- testCases := []testCase{
- {
- desc: "--keepsrc",
- wantShow: []string{
- "makepkg --nobuild -f --ignorearch",
- "makepkg --nobuild --noextract --ignorearch",
- "pacman -U --config -- /testdir/yay-92.0.0-1-x86_64.pkg.tar.zst",
- "pacman -D -q --asexplicit --config -- yay",
- },
- targets: []map[string]*dep.InstallInfo{
- {
- "yay": {
- Source: dep.AUR,
- Reason: dep.Explicit,
- Version: "92.0.0-1",
- SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
- AURBase: ptrString("yay"),
- },
- },
- },
- },
- }
- for _, tc := range testCases {
- tc := tc
- t.Run(tc.desc, func(td *testing.T) {
- tmpDir := td.TempDir()
- pkgTar := tmpDir + "/yay-92.0.0-1-x86_64.pkg.tar.zst"
- captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
- return pkgTar, "", nil
- }
- // create a mock file
- f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
- require.NoError(td, err)
- require.NoError(td, f.Close())
- mockDB := &mock.DBExecutor{}
- mockRunner := &exe.MockRunner{CaptureFn: captureOverride}
- cmdBuilder := &exe.CmdBuilder{
- MakepkgBin: makepkgBin,
- SudoBin: "su",
- PacmanBin: pacmanBin,
- KeepSrc: true,
- Runner: mockRunner,
- SudoLoopEnabled: false,
- }
- installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
- parser.RebuildModeNo, false, newTestLogger())
- cmdArgs := parser.MakeArguments()
- cmdArgs.AddTarget("yay")
- pkgBuildDirs := map[string]string{
- "yay": tmpDir,
- }
- errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
- require.NoError(td, errI)
- require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
- for i, call := range mockRunner.ShowCalls {
- show := call.Args[0].(*exec.Cmd).String()
- show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
- show = strings.ReplaceAll(show, makepkgBin, "makepkg")
- show = strings.ReplaceAll(show, pacmanBin, "pacman")
- // options are in a different order on different systems and on CI root user is used
- assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
- // Only assert makepkg commands don't have clean arguments
- if strings.HasPrefix(show, "makepkg") {
- assert.NotContains(td, show, "-c")
- assert.NotContains(td, show, "-C")
- }
- }
- })
- }
- }
|