installer_test.go 42 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443
  1. package build
  2. import (
  3. "context"
  4. "errors"
  5. "fmt"
  6. "io"
  7. "os"
  8. "os/exec"
  9. "strings"
  10. "testing"
  11. "github.com/stretchr/testify/assert"
  12. "github.com/stretchr/testify/require"
  13. "github.com/Jguer/yay/v12/pkg/db/mock"
  14. "github.com/Jguer/yay/v12/pkg/dep"
  15. "github.com/Jguer/yay/v12/pkg/settings/exe"
  16. "github.com/Jguer/yay/v12/pkg/settings/parser"
  17. "github.com/Jguer/yay/v12/pkg/text"
  18. "github.com/Jguer/yay/v12/pkg/vcs"
  19. )
  20. func newTestLogger() *text.Logger {
  21. return text.NewLogger(io.Discard, io.Discard, strings.NewReader(""), true, "test")
  22. }
  23. func ptrString(s string) *string {
  24. return &s
  25. }
  26. func TestInstaller_InstallNeeded(t *testing.T) {
  27. t.Parallel()
  28. makepkgBin := t.TempDir() + "/makepkg"
  29. pacmanBin := t.TempDir() + "/pacman"
  30. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  31. require.NoError(t, err)
  32. require.NoError(t, f.Close())
  33. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  34. require.NoError(t, err)
  35. require.NoError(t, f.Close())
  36. type testCase struct {
  37. desc string
  38. isInstalled bool
  39. isBuilt bool
  40. wantShow []string
  41. wantCapture []string
  42. }
  43. testCases := []testCase{
  44. {
  45. desc: "not installed and not built",
  46. isInstalled: false,
  47. isBuilt: false,
  48. wantShow: []string{
  49. "makepkg --nobuild -f -C --ignorearch",
  50. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  51. "pacman -U --needed --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  52. "pacman -D -q --asexplicit --config -- yay",
  53. },
  54. wantCapture: []string{"makepkg --packagelist"},
  55. },
  56. {
  57. desc: "not installed and built",
  58. isInstalled: false,
  59. isBuilt: true,
  60. wantShow: []string{
  61. "makepkg --nobuild -f -C --ignorearch",
  62. "makepkg -c --nobuild --noextract --ignorearch",
  63. "pacman -U --needed --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  64. "pacman -D -q --asexplicit --config -- yay",
  65. },
  66. wantCapture: []string{"makepkg --packagelist"},
  67. },
  68. {
  69. desc: "installed",
  70. isInstalled: true,
  71. isBuilt: false,
  72. wantShow: []string{
  73. "makepkg --nobuild -f -C --ignorearch",
  74. "makepkg -c --nobuild --noextract --ignorearch",
  75. },
  76. wantCapture: []string{"makepkg --packagelist"},
  77. },
  78. }
  79. for _, tc := range testCases {
  80. tc := tc
  81. t.Run(tc.desc, func(td *testing.T) {
  82. tmpDir := td.TempDir()
  83. pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
  84. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  85. return pkgTar, "", nil
  86. }
  87. i := 0
  88. showOverride := func(cmd *exec.Cmd) error {
  89. i++
  90. if i == 2 {
  91. if !tc.isBuilt {
  92. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  93. require.NoError(td, err)
  94. require.NoError(td, f.Close())
  95. }
  96. }
  97. return nil
  98. }
  99. // create a mock file
  100. if tc.isBuilt {
  101. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  102. require.NoError(td, err)
  103. require.NoError(td, f.Close())
  104. }
  105. isCorrectInstalledOverride := func(string, string) bool {
  106. return tc.isInstalled
  107. }
  108. mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
  109. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  110. cmdBuilder := &exe.CmdBuilder{
  111. MakepkgBin: makepkgBin,
  112. SudoBin: "su",
  113. PacmanBin: pacmanBin,
  114. Runner: mockRunner,
  115. SudoLoopEnabled: false,
  116. }
  117. cmdBuilder.Runner = mockRunner
  118. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  119. parser.RebuildModeNo, false, newTestLogger())
  120. cmdArgs := parser.MakeArguments()
  121. cmdArgs.AddArg("needed")
  122. cmdArgs.AddTarget("yay")
  123. pkgBuildDirs := map[string]string{
  124. "yay": tmpDir,
  125. }
  126. targets := []map[string]*dep.InstallInfo{
  127. {
  128. "yay": {
  129. Source: dep.AUR,
  130. Reason: dep.Explicit,
  131. Version: "91.0.0-1",
  132. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  133. AURBase: ptrString("yay"),
  134. },
  135. },
  136. }
  137. errI := installer.Install(context.Background(), cmdArgs, targets, pkgBuildDirs, []string{}, false)
  138. require.NoError(td, errI)
  139. require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
  140. require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
  141. for i, call := range mockRunner.ShowCalls {
  142. show := call.Args[0].(*exec.Cmd).String()
  143. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  144. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  145. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  146. // options are in a different order on different systems and on CI root user is used
  147. assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
  148. }
  149. for i, call := range mockRunner.CaptureCalls {
  150. capture := call.Args[0].(*exec.Cmd).String()
  151. capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
  152. capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
  153. capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
  154. assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
  155. }
  156. })
  157. }
  158. }
  159. func TestInstaller_InstallMixedSourcesAndLayers(t *testing.T) {
  160. t.Parallel()
  161. makepkgBin := t.TempDir() + "/makepkg"
  162. pacmanBin := t.TempDir() + "/pacman"
  163. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  164. require.NoError(t, err)
  165. require.NoError(t, f.Close())
  166. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  167. require.NoError(t, err)
  168. require.NoError(t, f.Close())
  169. type testCase struct {
  170. desc string
  171. targets []map[string]*dep.InstallInfo
  172. wantShow []string
  173. wantCapture []string
  174. }
  175. tmpDir := t.TempDir()
  176. tmpDirJfin := t.TempDir()
  177. testCases := []testCase{
  178. {
  179. desc: "same layer -- different sources",
  180. wantShow: []string{
  181. "pacman -S --config /etc/pacman.conf -- core/linux",
  182. "pacman -D -q --asdeps --config /etc/pacman.conf -- linux",
  183. "makepkg --nobuild -f -C --ignorearch",
  184. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  185. "pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  186. "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
  187. },
  188. wantCapture: []string{"makepkg --packagelist"},
  189. targets: []map[string]*dep.InstallInfo{
  190. {
  191. "yay": {
  192. Source: dep.AUR,
  193. Reason: dep.Explicit,
  194. Version: "91.0.0-1",
  195. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  196. AURBase: ptrString("yay"),
  197. },
  198. "linux": {
  199. Source: dep.Sync,
  200. Reason: dep.Dep,
  201. Version: "17.0.0-1",
  202. SyncDBName: ptrString("core"),
  203. },
  204. },
  205. },
  206. },
  207. {
  208. desc: "different layer -- different sources",
  209. wantShow: []string{
  210. "pacman -S --config /etc/pacman.conf -- core/linux",
  211. "pacman -D -q --asdeps --config /etc/pacman.conf -- linux",
  212. "makepkg --nobuild -f -C --ignorearch",
  213. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  214. "pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  215. "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
  216. },
  217. wantCapture: []string{"makepkg --packagelist"},
  218. targets: []map[string]*dep.InstallInfo{
  219. {
  220. "yay": {
  221. Source: dep.AUR,
  222. Reason: dep.Explicit,
  223. Version: "91.0.0-1",
  224. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  225. AURBase: ptrString("yay"),
  226. },
  227. }, {
  228. "linux": {
  229. Source: dep.Sync,
  230. Reason: dep.Dep,
  231. Version: "17.0.0-1",
  232. SyncDBName: ptrString("core"),
  233. },
  234. },
  235. },
  236. },
  237. {
  238. desc: "same layer -- sync",
  239. wantShow: []string{
  240. "pacman -S --config /etc/pacman.conf -- extra/linux-zen core/linux",
  241. "pacman -D -q --asexplicit --config /etc/pacman.conf -- linux-zen linux",
  242. },
  243. wantCapture: []string{},
  244. targets: []map[string]*dep.InstallInfo{
  245. {
  246. "linux-zen": {
  247. Source: dep.Sync,
  248. Reason: dep.Explicit,
  249. Version: "18.0.0-1",
  250. SyncDBName: ptrString("extra"),
  251. },
  252. "linux": {
  253. Source: dep.Sync,
  254. Reason: dep.Explicit,
  255. Version: "17.0.0-1",
  256. SyncDBName: ptrString("core"),
  257. },
  258. },
  259. },
  260. },
  261. {
  262. desc: "same layer -- aur",
  263. wantShow: []string{
  264. "makepkg --nobuild -f -C --ignorearch",
  265. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  266. "makepkg --nobuild -f -C --ignorearch",
  267. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  268. "pacman -U --config /etc/pacman.conf -- pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  269. "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
  270. },
  271. wantCapture: []string{"makepkg --packagelist", "makepkg --packagelist"},
  272. targets: []map[string]*dep.InstallInfo{
  273. {
  274. "yay": {
  275. Source: dep.AUR,
  276. Reason: dep.Explicit,
  277. Version: "91.0.0-1",
  278. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  279. AURBase: ptrString("yay"),
  280. },
  281. "jellyfin-server": {
  282. Source: dep.AUR,
  283. Reason: dep.Explicit,
  284. Version: "10.8.8-1",
  285. SrcinfoPath: ptrString(tmpDirJfin + "/.SRCINFO"),
  286. AURBase: ptrString("jellyfin"),
  287. },
  288. },
  289. },
  290. },
  291. {
  292. desc: "different layer -- aur",
  293. wantShow: []string{
  294. "makepkg --nobuild -f -C --ignorearch",
  295. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  296. "pacman -U --config /etc/pacman.conf -- pacman -U --config /etc/pacman.conf -- /testdir/jellyfin-server-10.8.8-1-x86_64.pkg.tar.zst",
  297. "pacman -D -q --asdeps --config /etc/pacman.conf -- jellyfin-server",
  298. "makepkg --nobuild -f -C --ignorearch",
  299. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  300. "pacman -U --config /etc/pacman.conf -- pacman -U --config /etc/pacman.conf -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  301. "pacman -D -q --asexplicit --config /etc/pacman.conf -- yay",
  302. },
  303. wantCapture: []string{"makepkg --packagelist", "makepkg --packagelist"},
  304. targets: []map[string]*dep.InstallInfo{
  305. {
  306. "yay": {
  307. Source: dep.AUR,
  308. Reason: dep.Explicit,
  309. Version: "91.0.0-1",
  310. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  311. AURBase: ptrString("yay"),
  312. },
  313. }, {
  314. "jellyfin-server": {
  315. Source: dep.AUR,
  316. Reason: dep.MakeDep,
  317. Version: "10.8.8-1",
  318. SrcinfoPath: ptrString(tmpDirJfin + "/.SRCINFO"),
  319. AURBase: ptrString("jellyfin"),
  320. },
  321. },
  322. },
  323. },
  324. }
  325. for _, tc := range testCases {
  326. tc := tc
  327. t.Run(tc.desc, func(td *testing.T) {
  328. pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
  329. jfinPkgTar := tmpDirJfin + "/jellyfin-server-10.8.8-1-x86_64.pkg.tar.zst"
  330. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  331. if cmd.Dir == tmpDirJfin {
  332. return jfinPkgTar, "", nil
  333. }
  334. if cmd.Dir == tmpDir {
  335. return pkgTar, "", nil
  336. }
  337. return "", "", fmt.Errorf("unexpected command: %s - %s", cmd.String(), cmd.Dir)
  338. }
  339. showOverride := func(cmd *exec.Cmd) error {
  340. if strings.Contains(cmd.String(), "makepkg -f --noconfirm") && cmd.Dir == tmpDir {
  341. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  342. require.NoError(td, err)
  343. require.NoError(td, f.Close())
  344. }
  345. if strings.Contains(cmd.String(), "makepkg -f --noconfirm") && cmd.Dir == tmpDirJfin {
  346. f, err := os.OpenFile(jfinPkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  347. require.NoError(td, err)
  348. require.NoError(td, f.Close())
  349. }
  350. return nil
  351. }
  352. defer os.Remove(pkgTar)
  353. defer os.Remove(jfinPkgTar)
  354. isCorrectInstalledOverride := func(string, string) bool {
  355. return false
  356. }
  357. mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
  358. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  359. cmdBuilder := &exe.CmdBuilder{
  360. MakepkgBin: makepkgBin,
  361. SudoBin: "su",
  362. PacmanBin: pacmanBin,
  363. PacmanConfigPath: "/etc/pacman.conf",
  364. Runner: mockRunner,
  365. SudoLoopEnabled: false,
  366. }
  367. cmdBuilder.Runner = mockRunner
  368. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny, parser.RebuildModeNo, false, newTestLogger())
  369. cmdArgs := parser.MakeArguments()
  370. cmdArgs.AddTarget("yay")
  371. pkgBuildDirs := map[string]string{
  372. "yay": tmpDir,
  373. "jellyfin": tmpDirJfin,
  374. }
  375. errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
  376. require.NoError(td, errI)
  377. require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
  378. require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
  379. for i, call := range mockRunner.ShowCalls {
  380. show := call.Args[0].(*exec.Cmd).String()
  381. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  382. show = strings.ReplaceAll(show, tmpDirJfin, "/testdir") // replace the temp dir with a static path
  383. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  384. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  385. // options are in a different order on different systems and on CI root user is used
  386. assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
  387. }
  388. for i, call := range mockRunner.CaptureCalls {
  389. capture := call.Args[0].(*exec.Cmd).String()
  390. capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
  391. capture = strings.ReplaceAll(capture, tmpDirJfin, "/testdir")
  392. capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
  393. capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
  394. assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
  395. }
  396. })
  397. }
  398. }
  399. func TestInstaller_RunPostHooks(t *testing.T) {
  400. mockDB := &mock.DBExecutor{}
  401. mockRunner := &exe.MockRunner{}
  402. cmdBuilder := &exe.CmdBuilder{
  403. MakepkgBin: "makepkg",
  404. SudoBin: "su",
  405. PacmanBin: "pacman",
  406. PacmanConfigPath: "/etc/pacman.conf",
  407. Runner: mockRunner,
  408. SudoLoopEnabled: false,
  409. }
  410. cmdBuilder.Runner = mockRunner
  411. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  412. parser.RebuildModeNo, false, newTestLogger())
  413. called := false
  414. hook := func(ctx context.Context) error {
  415. called = true
  416. return nil
  417. }
  418. installer.AddPostInstallHook(hook)
  419. installer.RunPostInstallHooks(context.Background())
  420. assert.True(t, called)
  421. }
  422. func TestInstaller_CompileFailed(t *testing.T) {
  423. t.Parallel()
  424. makepkgBin := t.TempDir() + "/makepkg"
  425. pacmanBin := t.TempDir() + "/pacman"
  426. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  427. require.NoError(t, err)
  428. require.NoError(t, f.Close())
  429. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  430. require.NoError(t, err)
  431. require.NoError(t, f.Close())
  432. type testCase struct {
  433. desc string
  434. targets []map[string]*dep.InstallInfo
  435. wantErrInstall bool
  436. wantErrCompile bool
  437. failBuild bool
  438. failPkgInstall bool
  439. }
  440. tmpDir := t.TempDir()
  441. testCases := []testCase{
  442. {
  443. desc: "one layer",
  444. wantErrInstall: false,
  445. wantErrCompile: true,
  446. failBuild: true,
  447. failPkgInstall: false,
  448. targets: []map[string]*dep.InstallInfo{
  449. {
  450. "yay": {
  451. Source: dep.AUR,
  452. Reason: dep.Explicit,
  453. Version: "91.0.0-1",
  454. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  455. AURBase: ptrString("yay"),
  456. },
  457. },
  458. },
  459. },
  460. {
  461. desc: "one layer -- fail install",
  462. wantErrInstall: true,
  463. wantErrCompile: false,
  464. failBuild: false,
  465. failPkgInstall: true,
  466. targets: []map[string]*dep.InstallInfo{
  467. {
  468. "yay": {
  469. Source: dep.AUR,
  470. Reason: dep.Explicit,
  471. Version: "91.0.0-1",
  472. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  473. AURBase: ptrString("yay"),
  474. },
  475. },
  476. },
  477. },
  478. {
  479. desc: "two layers",
  480. wantErrInstall: false,
  481. wantErrCompile: true,
  482. failBuild: true,
  483. failPkgInstall: false,
  484. targets: []map[string]*dep.InstallInfo{
  485. {"bob": {
  486. AURBase: ptrString("yay"),
  487. }},
  488. {
  489. "yay": {
  490. Source: dep.AUR,
  491. Reason: dep.Explicit,
  492. Version: "91.0.0-1",
  493. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  494. AURBase: ptrString("yay"),
  495. },
  496. },
  497. },
  498. },
  499. }
  500. for _, tc := range testCases {
  501. tc := tc
  502. t.Run(tc.desc, func(td *testing.T) {
  503. pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
  504. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  505. return pkgTar, "", nil
  506. }
  507. showOverride := func(cmd *exec.Cmd) error {
  508. if tc.failBuild && strings.Contains(cmd.String(), "makepkg -f --noconfirm") && cmd.Dir == tmpDir {
  509. return errors.New("makepkg failed")
  510. }
  511. return nil
  512. }
  513. isCorrectInstalledOverride := func(string, string) bool {
  514. return false
  515. }
  516. mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
  517. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  518. cmdBuilder := &exe.CmdBuilder{
  519. MakepkgBin: makepkgBin,
  520. SudoBin: "su",
  521. PacmanBin: pacmanBin,
  522. Runner: mockRunner,
  523. SudoLoopEnabled: false,
  524. }
  525. cmdBuilder.Runner = mockRunner
  526. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  527. parser.RebuildModeNo, false, newTestLogger())
  528. cmdArgs := parser.MakeArguments()
  529. cmdArgs.AddArg("needed")
  530. cmdArgs.AddTarget("yay")
  531. pkgBuildDirs := map[string]string{
  532. "yay": tmpDir,
  533. }
  534. errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
  535. if tc.wantErrInstall {
  536. require.Error(td, errI)
  537. } else {
  538. require.NoError(td, errI)
  539. }
  540. failed, err := installer.CompileFailedAndIgnored()
  541. if tc.wantErrCompile {
  542. require.Error(td, err)
  543. assert.ErrorContains(td, err, "yay")
  544. assert.Len(t, failed, len(tc.targets))
  545. } else {
  546. require.NoError(td, err)
  547. }
  548. })
  549. }
  550. }
  551. func TestInstaller_InstallSplitPackage(t *testing.T) {
  552. t.Parallel()
  553. makepkgBin := t.TempDir() + "/makepkg"
  554. pacmanBin := t.TempDir() + "/pacman"
  555. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  556. require.NoError(t, err)
  557. require.NoError(t, f.Close())
  558. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  559. require.NoError(t, err)
  560. require.NoError(t, f.Close())
  561. type testCase struct {
  562. desc string
  563. wantShow []string
  564. wantCapture []string
  565. targets []map[string]*dep.InstallInfo
  566. }
  567. tmpDir := t.TempDir()
  568. testCases := []testCase{
  569. {
  570. desc: "jellyfin",
  571. targets: []map[string]*dep.InstallInfo{
  572. {"jellyfin": {
  573. Source: dep.AUR,
  574. Reason: dep.Explicit,
  575. Version: "10.8.4-1",
  576. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  577. AURBase: ptrString("jellyfin"),
  578. }},
  579. {
  580. "jellyfin-server": {
  581. Source: dep.AUR,
  582. Reason: dep.Dep,
  583. Version: "10.8.4-1",
  584. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  585. AURBase: ptrString("jellyfin"),
  586. },
  587. "jellyfin-web": {
  588. Source: dep.AUR,
  589. Reason: dep.Dep,
  590. Version: "10.8.4-1",
  591. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  592. AURBase: ptrString("jellyfin"),
  593. },
  594. },
  595. {
  596. "dotnet-runtime-6.0": {
  597. Source: dep.Sync,
  598. Reason: dep.Dep,
  599. Version: "6.0.12.sdk112-1",
  600. SyncDBName: ptrString("community"),
  601. },
  602. "aspnet-runtime": {
  603. Source: dep.Sync,
  604. Reason: dep.Dep,
  605. Version: "6.0.12.sdk112-1",
  606. SyncDBName: ptrString("community"),
  607. },
  608. "dotnet-sdk-6.0": {
  609. Source: dep.Sync,
  610. Reason: dep.MakeDep,
  611. Version: "6.0.12.sdk112-1",
  612. SyncDBName: ptrString("community"),
  613. },
  614. },
  615. },
  616. wantShow: []string{
  617. "pacman -S --config /etc/pacman.conf -- community/dotnet-runtime-6.0 community/aspnet-runtime community/dotnet-sdk-6.0",
  618. "pacman -D -q --asdeps --config /etc/pacman.conf -- dotnet-runtime-6.0 aspnet-runtime dotnet-sdk-6.0",
  619. "makepkg --nobuild -f -C --ignorearch",
  620. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  621. "makepkg --nobuild -f -C --ignorearch",
  622. "makepkg -c --nobuild --noextract --ignorearch",
  623. "pacman -U --config /etc/pacman.conf -- /testdir/jellyfin-web-10.8.4-1-x86_64.pkg.tar.zst /testdir/jellyfin-server-10.8.4-1-x86_64.pkg.tar.zst",
  624. "pacman -D -q --asdeps --config /etc/pacman.conf -- jellyfin-server jellyfin-web",
  625. "makepkg --nobuild -f -C --ignorearch",
  626. "makepkg -c --nobuild --noextract --ignorearch",
  627. "pacman -U --config /etc/pacman.conf -- /testdir/jellyfin-10.8.4-1-x86_64.pkg.tar.zst",
  628. "pacman -D -q --asexplicit --config /etc/pacman.conf -- jellyfin",
  629. },
  630. wantCapture: []string{"makepkg --packagelist", "makepkg --packagelist", "makepkg --packagelist"},
  631. },
  632. }
  633. for _, tc := range testCases {
  634. tc := tc
  635. t.Run(tc.desc, func(td *testing.T) {
  636. pkgTars := []string{
  637. tmpDir + "/jellyfin-10.8.4-1-x86_64.pkg.tar.zst",
  638. tmpDir + "/jellyfin-web-10.8.4-1-x86_64.pkg.tar.zst",
  639. tmpDir + "/jellyfin-server-10.8.4-1-x86_64.pkg.tar.zst",
  640. }
  641. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  642. return strings.Join(pkgTars, "\n"), "", nil
  643. }
  644. i := 0
  645. showOverride := func(cmd *exec.Cmd) error {
  646. i++
  647. if i == 4 {
  648. for _, pkgTar := range pkgTars {
  649. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  650. require.NoError(td, err)
  651. require.NoError(td, f.Close())
  652. }
  653. }
  654. return nil
  655. }
  656. isCorrectInstalledOverride := func(string, string) bool {
  657. return false
  658. }
  659. mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
  660. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  661. cmdBuilder := &exe.CmdBuilder{
  662. MakepkgBin: makepkgBin,
  663. SudoBin: "su",
  664. PacmanBin: pacmanBin,
  665. PacmanConfigPath: "/etc/pacman.conf",
  666. Runner: mockRunner,
  667. SudoLoopEnabled: false,
  668. }
  669. cmdBuilder.Runner = mockRunner
  670. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  671. parser.RebuildModeNo, false, newTestLogger())
  672. cmdArgs := parser.MakeArguments()
  673. cmdArgs.AddTarget("jellyfin")
  674. pkgBuildDirs := map[string]string{
  675. "jellyfin": tmpDir,
  676. }
  677. errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
  678. require.NoError(td, errI)
  679. require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
  680. require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
  681. for i, call := range mockRunner.ShowCalls {
  682. show := call.Args[0].(*exec.Cmd).String()
  683. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  684. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  685. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  686. // options are in a different order on different systems and on CI root user is used
  687. assert.Subset(td, strings.Split(show, " "),
  688. strings.Split(tc.wantShow[i], " "),
  689. fmt.Sprintf("got at %d: %s \n", i, show))
  690. }
  691. for i, call := range mockRunner.CaptureCalls {
  692. capture := call.Args[0].(*exec.Cmd).String()
  693. capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
  694. capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
  695. capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
  696. assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
  697. }
  698. })
  699. }
  700. }
  701. func TestInstaller_InstallDownloadOnly(t *testing.T) {
  702. t.Parallel()
  703. makepkgBin := t.TempDir() + "/makepkg"
  704. pacmanBin := t.TempDir() + "/pacman"
  705. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  706. require.NoError(t, err)
  707. require.NoError(t, f.Close())
  708. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  709. require.NoError(t, err)
  710. require.NoError(t, f.Close())
  711. type testCase struct {
  712. desc string
  713. isInstalled bool
  714. isBuilt bool
  715. wantShow []string
  716. wantCapture []string
  717. }
  718. testCases := []testCase{
  719. {
  720. desc: "not installed and not built",
  721. isInstalled: false,
  722. isBuilt: false,
  723. wantShow: []string{
  724. "makepkg --nobuild -f -C --ignorearch",
  725. "makepkg -c --nobuild --noextract --ignorearch",
  726. },
  727. wantCapture: []string{"makepkg --packagelist"},
  728. },
  729. {
  730. desc: "not installed and built",
  731. isInstalled: false,
  732. isBuilt: true,
  733. wantShow: []string{
  734. "makepkg --nobuild -f -C --ignorearch",
  735. "makepkg -c --nobuild --noextract --ignorearch",
  736. },
  737. wantCapture: []string{"makepkg --packagelist"},
  738. },
  739. {
  740. desc: "installed",
  741. isInstalled: true,
  742. isBuilt: false,
  743. wantShow: []string{
  744. "makepkg --nobuild -f -C --ignorearch",
  745. "makepkg -c --nobuild --noextract --ignorearch",
  746. },
  747. wantCapture: []string{"makepkg --packagelist"},
  748. },
  749. }
  750. for _, tc := range testCases {
  751. tc := tc
  752. t.Run(tc.desc, func(td *testing.T) {
  753. tmpDir := td.TempDir()
  754. pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
  755. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  756. return pkgTar, "", nil
  757. }
  758. i := 0
  759. showOverride := func(cmd *exec.Cmd) error {
  760. i++
  761. if i == 2 {
  762. if !tc.isBuilt {
  763. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  764. require.NoError(td, err)
  765. require.NoError(td, f.Close())
  766. }
  767. }
  768. return nil
  769. }
  770. // create a mock file
  771. if tc.isBuilt {
  772. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  773. require.NoError(td, err)
  774. require.NoError(td, f.Close())
  775. }
  776. isCorrectInstalledOverride := func(string, string) bool {
  777. return tc.isInstalled
  778. }
  779. mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
  780. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  781. cmdBuilder := &exe.CmdBuilder{
  782. MakepkgBin: makepkgBin,
  783. SudoBin: "su",
  784. PacmanBin: pacmanBin,
  785. Runner: mockRunner,
  786. SudoLoopEnabled: false,
  787. }
  788. cmdBuilder.Runner = mockRunner
  789. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  790. parser.RebuildModeNo, true, newTestLogger())
  791. cmdArgs := parser.MakeArguments()
  792. cmdArgs.AddTarget("yay")
  793. pkgBuildDirs := map[string]string{
  794. "yay": tmpDir,
  795. }
  796. targets := []map[string]*dep.InstallInfo{
  797. {
  798. "yay": {
  799. Source: dep.AUR,
  800. Reason: dep.Explicit,
  801. Version: "91.0.0-1",
  802. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  803. AURBase: ptrString("yay"),
  804. },
  805. },
  806. }
  807. errI := installer.Install(context.Background(), cmdArgs, targets, pkgBuildDirs, []string{}, false)
  808. require.NoError(td, errI)
  809. require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
  810. require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
  811. require.Empty(td, installer.failedAndIgnored)
  812. for i, call := range mockRunner.ShowCalls {
  813. show := call.Args[0].(*exec.Cmd).String()
  814. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  815. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  816. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  817. // options are in a different order on different systems and on CI root user is used
  818. assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
  819. }
  820. for i, call := range mockRunner.CaptureCalls {
  821. capture := call.Args[0].(*exec.Cmd).String()
  822. capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
  823. capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
  824. capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
  825. assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
  826. }
  827. })
  828. }
  829. }
  830. func TestInstaller_InstallGroup(t *testing.T) {
  831. t.Parallel()
  832. makepkgBin := t.TempDir() + "/makepkg"
  833. pacmanBin := t.TempDir() + "/pacman"
  834. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  835. require.NoError(t, err)
  836. require.NoError(t, f.Close())
  837. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  838. require.NoError(t, err)
  839. require.NoError(t, f.Close())
  840. type testCase struct {
  841. desc string
  842. wantShow []string
  843. wantCapture []string
  844. }
  845. testCases := []testCase{
  846. {
  847. desc: "group",
  848. wantShow: []string{
  849. "pacman -S --noconfirm --config -- community/kubernetes-tools",
  850. },
  851. wantCapture: []string{},
  852. },
  853. }
  854. for _, tc := range testCases {
  855. tc := tc
  856. t.Run(tc.desc, func(td *testing.T) {
  857. tmpDir := td.TempDir()
  858. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  859. return "", "", nil
  860. }
  861. showOverride := func(cmd *exec.Cmd) error {
  862. return nil
  863. }
  864. mockDB := &mock.DBExecutor{}
  865. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  866. cmdBuilder := &exe.CmdBuilder{
  867. MakepkgBin: makepkgBin,
  868. SudoBin: "su",
  869. PacmanBin: pacmanBin,
  870. Runner: mockRunner,
  871. SudoLoopEnabled: false,
  872. }
  873. cmdBuilder.Runner = mockRunner
  874. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  875. parser.RebuildModeNo, true, newTestLogger())
  876. cmdArgs := parser.MakeArguments()
  877. cmdArgs.AddTarget("kubernetes-tools")
  878. pkgBuildDirs := map[string]string{}
  879. targets := []map[string]*dep.InstallInfo{
  880. {
  881. "kubernetes-tools": {
  882. Source: dep.Sync,
  883. Reason: dep.Explicit,
  884. Version: "",
  885. IsGroup: true,
  886. SyncDBName: ptrString("community"),
  887. },
  888. },
  889. }
  890. errI := installer.Install(context.Background(), cmdArgs, targets, pkgBuildDirs, []string{}, false)
  891. require.NoError(td, errI)
  892. require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
  893. require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
  894. require.Empty(td, installer.failedAndIgnored)
  895. for i, call := range mockRunner.ShowCalls {
  896. show := call.Args[0].(*exec.Cmd).String()
  897. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  898. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  899. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  900. // options are in a different order on different systems and on CI root user is used
  901. assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
  902. }
  903. for i, call := range mockRunner.CaptureCalls {
  904. capture := call.Args[0].(*exec.Cmd).String()
  905. capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
  906. capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
  907. capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
  908. assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
  909. }
  910. })
  911. }
  912. }
  913. func TestInstaller_InstallRebuild(t *testing.T) {
  914. t.Parallel()
  915. makepkgBin := t.TempDir() + "/makepkg"
  916. pacmanBin := t.TempDir() + "/pacman"
  917. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  918. require.NoError(t, err)
  919. require.NoError(t, f.Close())
  920. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  921. require.NoError(t, err)
  922. require.NoError(t, f.Close())
  923. type testCase struct {
  924. desc string
  925. rebuildOption parser.RebuildMode
  926. isInstalled bool
  927. isBuilt bool
  928. wantShow []string
  929. wantCapture []string
  930. targets []map[string]*dep.InstallInfo
  931. }
  932. tmpDir := t.TempDir()
  933. testCases := []testCase{
  934. {
  935. desc: "--norebuild(default) when built and not installed",
  936. rebuildOption: parser.RebuildModeNo,
  937. isBuilt: true,
  938. isInstalled: false,
  939. wantShow: []string{
  940. "makepkg --nobuild -f -C --ignorearch",
  941. "makepkg -c --nobuild --noextract --ignorearch",
  942. "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  943. "pacman -D -q --asexplicit --config -- yay",
  944. },
  945. wantCapture: []string{"makepkg --packagelist"},
  946. targets: []map[string]*dep.InstallInfo{
  947. {
  948. "yay": {
  949. Source: dep.AUR,
  950. Reason: dep.Explicit,
  951. Version: "91.0.0-1",
  952. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  953. AURBase: ptrString("yay"),
  954. },
  955. },
  956. },
  957. },
  958. {
  959. desc: "--rebuild when built and not installed",
  960. rebuildOption: parser.RebuildModeYes,
  961. isBuilt: true,
  962. isInstalled: false,
  963. wantShow: []string{
  964. "makepkg --nobuild -f -C --ignorearch",
  965. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  966. "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  967. "pacman -D -q --asexplicit --config -- yay",
  968. },
  969. wantCapture: []string{"makepkg --packagelist"},
  970. targets: []map[string]*dep.InstallInfo{
  971. {
  972. "yay": {
  973. Source: dep.AUR,
  974. Reason: dep.Explicit,
  975. Version: "91.0.0-1",
  976. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  977. AURBase: ptrString("yay"),
  978. },
  979. },
  980. },
  981. },
  982. {
  983. desc: "--rebuild when built and installed",
  984. rebuildOption: parser.RebuildModeYes,
  985. isInstalled: true,
  986. isBuilt: true,
  987. wantShow: []string{
  988. "makepkg --nobuild -f -C --ignorearch",
  989. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  990. "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  991. "pacman -D -q --asexplicit --config -- yay",
  992. },
  993. wantCapture: []string{"makepkg --packagelist"},
  994. targets: []map[string]*dep.InstallInfo{
  995. {
  996. "yay": {
  997. Source: dep.AUR,
  998. Reason: dep.Explicit,
  999. Version: "91.0.0-1",
  1000. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  1001. AURBase: ptrString("yay"),
  1002. },
  1003. },
  1004. },
  1005. },
  1006. {
  1007. desc: "--rebuild when built and installed previously as dep",
  1008. rebuildOption: parser.RebuildModeYes,
  1009. isInstalled: true,
  1010. isBuilt: true,
  1011. wantShow: []string{
  1012. "makepkg --nobuild -f -C --ignorearch",
  1013. "makepkg -f -c --noconfirm --noextract --noprepare --holdver --ignorearch",
  1014. "pacman -U --config -- /testdir/yay-91.0.0-1-x86_64.pkg.tar.zst",
  1015. "pacman -D -q --asdeps --config -- yay",
  1016. },
  1017. wantCapture: []string{"makepkg --packagelist"},
  1018. targets: []map[string]*dep.InstallInfo{
  1019. {
  1020. "yay": {
  1021. Source: dep.AUR,
  1022. Reason: dep.Dep,
  1023. Version: "91.0.0-1",
  1024. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  1025. AURBase: ptrString("yay"),
  1026. },
  1027. },
  1028. },
  1029. },
  1030. }
  1031. for _, tc := range testCases {
  1032. tc := tc
  1033. t.Run(tc.desc, func(td *testing.T) {
  1034. tmpDir := td.TempDir()
  1035. pkgTar := tmpDir + "/yay-91.0.0-1-x86_64.pkg.tar.zst"
  1036. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  1037. return pkgTar, "", nil
  1038. }
  1039. i := 0
  1040. showOverride := func(cmd *exec.Cmd) error {
  1041. i++
  1042. if i == 2 {
  1043. if !tc.isBuilt {
  1044. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  1045. require.NoError(td, err)
  1046. require.NoError(td, f.Close())
  1047. }
  1048. }
  1049. return nil
  1050. }
  1051. // create a mock file
  1052. if tc.isBuilt {
  1053. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  1054. require.NoError(td, err)
  1055. require.NoError(td, f.Close())
  1056. }
  1057. isCorrectInstalledOverride := func(string, string) bool {
  1058. return tc.isInstalled
  1059. }
  1060. mockDB := &mock.DBExecutor{IsCorrectVersionInstalledFn: isCorrectInstalledOverride}
  1061. mockRunner := &exe.MockRunner{CaptureFn: captureOverride, ShowFn: showOverride}
  1062. cmdBuilder := &exe.CmdBuilder{
  1063. MakepkgBin: makepkgBin,
  1064. SudoBin: "su",
  1065. PacmanBin: pacmanBin,
  1066. Runner: mockRunner,
  1067. SudoLoopEnabled: false,
  1068. }
  1069. cmdBuilder.Runner = mockRunner
  1070. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  1071. tc.rebuildOption, false, newTestLogger())
  1072. cmdArgs := parser.MakeArguments()
  1073. cmdArgs.AddTarget("yay")
  1074. pkgBuildDirs := map[string]string{
  1075. "yay": tmpDir,
  1076. }
  1077. errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
  1078. require.NoError(td, errI)
  1079. require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
  1080. require.Len(td, mockRunner.CaptureCalls, len(tc.wantCapture))
  1081. for i, call := range mockRunner.ShowCalls {
  1082. show := call.Args[0].(*exec.Cmd).String()
  1083. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  1084. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  1085. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  1086. // options are in a different order on different systems and on CI root user is used
  1087. assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
  1088. }
  1089. for i, call := range mockRunner.CaptureCalls {
  1090. capture := call.Args[0].(*exec.Cmd).String()
  1091. capture = strings.ReplaceAll(capture, tmpDir, "/testdir") // replace the temp dir with a static path
  1092. capture = strings.ReplaceAll(capture, makepkgBin, "makepkg")
  1093. capture = strings.ReplaceAll(capture, pacmanBin, "pacman")
  1094. assert.Subset(td, strings.Split(capture, " "), strings.Split(tc.wantCapture[i], " "), capture)
  1095. }
  1096. })
  1097. }
  1098. }
  1099. func TestInstaller_InstallUpgrade(t *testing.T) {
  1100. t.Parallel()
  1101. makepkgBin := t.TempDir() + "/makepkg"
  1102. pacmanBin := t.TempDir() + "/pacman"
  1103. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  1104. require.NoError(t, err)
  1105. require.NoError(t, f.Close())
  1106. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  1107. require.NoError(t, err)
  1108. require.NoError(t, f.Close())
  1109. type testCase struct {
  1110. desc string
  1111. targetMode parser.TargetMode
  1112. }
  1113. tmpDir := t.TempDir()
  1114. testCases := []testCase{
  1115. {
  1116. desc: "target any",
  1117. targetMode: parser.ModeAny,
  1118. },
  1119. {
  1120. desc: "target repo",
  1121. targetMode: parser.ModeRepo,
  1122. },
  1123. {
  1124. desc: "target aur",
  1125. targetMode: parser.ModeAUR,
  1126. },
  1127. }
  1128. for _, tc := range testCases {
  1129. tc := tc
  1130. t.Run(tc.desc, func(td *testing.T) {
  1131. mockDB := &mock.DBExecutor{}
  1132. mockRunner := &exe.MockRunner{}
  1133. cmdBuilder := &exe.CmdBuilder{
  1134. MakepkgBin: makepkgBin,
  1135. SudoBin: "su",
  1136. PacmanBin: pacmanBin,
  1137. Runner: mockRunner,
  1138. SudoLoopEnabled: false,
  1139. }
  1140. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, tc.targetMode,
  1141. parser.RebuildModeNo, false, newTestLogger())
  1142. cmdArgs := parser.MakeArguments()
  1143. cmdArgs.AddArg("u", "upgrades") // Make sure both args are removed
  1144. targets := []map[string]*dep.InstallInfo{
  1145. {
  1146. "linux": {
  1147. Source: dep.Sync,
  1148. Reason: dep.Dep,
  1149. Version: "17.0.0-1",
  1150. SyncDBName: ptrString("core"),
  1151. },
  1152. },
  1153. }
  1154. errI := installer.Install(context.Background(), cmdArgs, targets, map[string]string{}, []string{}, false)
  1155. require.NoError(td, errI)
  1156. require.NotEmpty(td, mockRunner.ShowCalls)
  1157. // The first call is the only call being test
  1158. call := mockRunner.ShowCalls[0]
  1159. show := call.Args[0].(*exec.Cmd).String()
  1160. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  1161. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  1162. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  1163. if tc.targetMode == parser.ModeAUR {
  1164. assert.NotContains(td, show, "--upgrades")
  1165. assert.NotContains(td, show, "-u")
  1166. } else {
  1167. assert.Contains(td, show, "--upgrades")
  1168. assert.Contains(td, show, "-u")
  1169. }
  1170. })
  1171. }
  1172. }
  1173. func TestInstaller_KeepSrc(t *testing.T) {
  1174. t.Parallel()
  1175. makepkgBin := t.TempDir() + "/makepkg"
  1176. pacmanBin := t.TempDir() + "/pacman"
  1177. f, err := os.OpenFile(makepkgBin, os.O_RDONLY|os.O_CREATE, 0o755)
  1178. require.NoError(t, err)
  1179. require.NoError(t, f.Close())
  1180. f, err = os.OpenFile(pacmanBin, os.O_RDONLY|os.O_CREATE, 0o755)
  1181. require.NoError(t, err)
  1182. require.NoError(t, f.Close())
  1183. type testCase struct {
  1184. desc string
  1185. wantShow []string
  1186. targets []map[string]*dep.InstallInfo
  1187. }
  1188. tmpDir := t.TempDir()
  1189. testCases := []testCase{
  1190. {
  1191. desc: "--keepsrc",
  1192. wantShow: []string{
  1193. "makepkg --nobuild -f --ignorearch",
  1194. "makepkg --nobuild --noextract --ignorearch",
  1195. "pacman -U --config -- /testdir/yay-92.0.0-1-x86_64.pkg.tar.zst",
  1196. "pacman -D -q --asexplicit --config -- yay",
  1197. },
  1198. targets: []map[string]*dep.InstallInfo{
  1199. {
  1200. "yay": {
  1201. Source: dep.AUR,
  1202. Reason: dep.Explicit,
  1203. Version: "92.0.0-1",
  1204. SrcinfoPath: ptrString(tmpDir + "/.SRCINFO"),
  1205. AURBase: ptrString("yay"),
  1206. },
  1207. },
  1208. },
  1209. },
  1210. }
  1211. for _, tc := range testCases {
  1212. tc := tc
  1213. t.Run(tc.desc, func(td *testing.T) {
  1214. tmpDir := td.TempDir()
  1215. pkgTar := tmpDir + "/yay-92.0.0-1-x86_64.pkg.tar.zst"
  1216. captureOverride := func(cmd *exec.Cmd) (stdout string, stderr string, err error) {
  1217. return pkgTar, "", nil
  1218. }
  1219. // create a mock file
  1220. f, err := os.OpenFile(pkgTar, os.O_RDONLY|os.O_CREATE, 0o666)
  1221. require.NoError(td, err)
  1222. require.NoError(td, f.Close())
  1223. mockDB := &mock.DBExecutor{}
  1224. mockRunner := &exe.MockRunner{CaptureFn: captureOverride}
  1225. cmdBuilder := &exe.CmdBuilder{
  1226. MakepkgBin: makepkgBin,
  1227. SudoBin: "su",
  1228. PacmanBin: pacmanBin,
  1229. KeepSrc: true,
  1230. Runner: mockRunner,
  1231. SudoLoopEnabled: false,
  1232. }
  1233. installer := NewInstaller(mockDB, cmdBuilder, &vcs.Mock{}, parser.ModeAny,
  1234. parser.RebuildModeNo, false, newTestLogger())
  1235. cmdArgs := parser.MakeArguments()
  1236. cmdArgs.AddTarget("yay")
  1237. pkgBuildDirs := map[string]string{
  1238. "yay": tmpDir,
  1239. }
  1240. errI := installer.Install(context.Background(), cmdArgs, tc.targets, pkgBuildDirs, []string{}, false)
  1241. require.NoError(td, errI)
  1242. require.Len(td, mockRunner.ShowCalls, len(tc.wantShow))
  1243. for i, call := range mockRunner.ShowCalls {
  1244. show := call.Args[0].(*exec.Cmd).String()
  1245. show = strings.ReplaceAll(show, tmpDir, "/testdir") // replace the temp dir with a static path
  1246. show = strings.ReplaceAll(show, makepkgBin, "makepkg")
  1247. show = strings.ReplaceAll(show, pacmanBin, "pacman")
  1248. // options are in a different order on different systems and on CI root user is used
  1249. assert.Subset(td, strings.Split(show, " "), strings.Split(tc.wantShow[i], " "), show)
  1250. // Only assert makepkg commands don't have clean arguments
  1251. if strings.HasPrefix(show, "makepkg") {
  1252. assert.NotContains(td, show, "-c")
  1253. assert.NotContains(td, show, "-C")
  1254. }
  1255. }
  1256. })
  1257. }
  1258. }